fix: URL having Anchor element isn't displaying as expected - EXO-73493 - Meeds-io/meeds#2665. #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mme prévu - EXO-73493 - Meeds-io/meeds#2665. Avant ce changement, sur le flux d'activité, cliquez sur l'URL de news contenant des ancres, les news affichées ayant le tiroir de commentaires ouvert. Pour résoudre ce problème, ajoutez une condition avant l'ouverture du tiroir de commentaires si le hash n'est pas un id du commentaire ajouter l'id du hash dans l'URL sans l'ouvrir du tiroir. Après ce changement, les news s'affichent en se concentrant sur l'ancre sans ouvrir les commentaires.
|
akhanfir
changed the title
mkrout
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, on Activity stream, click on news URL having anchors, news displayed having comment drawer opened. To resolve this problem, add a condition before opening the comments drawer if the hash is not an id of the comment add the id of the hash in the URL without opening it from the drawer. After this change, the news is displayed focusing on anchor without opening the comments.