fix: Comments link are no longer considered to be displayed - EXO-76566 - Meeds-io/meeds#2771. #4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… - Meeds-io/meeds#2771. Before this change, when create a postX and comment it then get the comment link and open it in new tab, post is displayed. To resolve this problem, add a condition to the creation of the URL to check if the id in the parameter passed in the URL has a text comment if yes opens the comment drawer. After this change, the link is display post and having its comment drawer opened focusing on comment retrieved.
|
mkrout
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when create a postX and comment it then get the comment link and open it in new tab, post is displayed. To resolve this problem, add a condition to the creation of the URL to check if the id in the parameter passed in the URL has a text comment if yes opens the comment drawer. After this change, the link is display post and having its comment drawer opened focusing on comment retrieved.