Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add simple storage portlet - MEED-8221 - Meeds-io/MIPs#176 #4383

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

hakermi
Copy link
Member

@hakermi hakermi commented Jan 28, 2025

Add simple storage portlet

@hakermi hakermi requested a review from rdenarie January 28, 2025 12:46
@github-actions github-actions bot added the partialCIBuild Perform Partial CI Build label Jan 28, 2025
@hakermi hakermi force-pushed the TASK-8221 branch 2 times, most recently from 348561e to 4821157 Compare January 28, 2025 13:00
@hakermi hakermi requested a review from boubaker January 28, 2025 13:01
Copy link
Member

@boubaker boubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fixes. Can you please add the new I18N file in

social/crowdin.yml

Lines 561 to 577 in 3be63b0

{
"source": "/webapp/src/main/resources/locale/portlet/SpaceTemplatesManagement_en.properties",
"translation": "%original_path%/%file_name%!_%locale_with_underscore%.%file_extension%",
"translation_replace": {
"_en!": "","ar_SA": "ar","ar_OM": "aro","az_AZ": "az","ca_ES": "ca","ceb_PH": "ceb",
"co_FR": "co","cs_CZ": "cs","de_DE": "de","el_GR": "el","en_US": "en","es_ES": "es_ES","eu_ES": "eu","fa_IR": "fa",
"fi_FI": "fi","fil_PH": "fil","fr_FR": "fr","hi_IN": "hi","hu_HU": "hu","id_ID": "id","it_IT": "it","ja_JP": "ja",
"kab_KAB": "kab","ko_KR": "ko","lt_LT": "lt","ms_MY": "ms","nl_NL": "nl","no_NO": "no","pcm_NG": "pcm","pl_PL": "pl",
"pt_BR": "pt_BR","pt_PT": "pt_PT","ro_RO": "ro","ru_RU": "ru","sk_SK": "sk","sl_SI": "sl","sq_AL": "sq",
"sv_SE": "sv_SE","th_TH": "th","tl_PH": "tl","tr_TR": "tr","uk_UA": "uk","ur_IN": "ur_IN","vi_VN": "vi",
"zh_CN": "zh_CN","zh_TW": "zh_TW",
},
"dest": "hub/social/webapp/SpaceTemplatesManagement.properties",
"update_option": "update_as_unapproved",
"escape_special_characters": 0,
"escape_quotes": 0,
},
in order to allow Synchronization with Crowdin after merging on Develop.

@hakermi hakermi requested a review from boubaker January 28, 2025 13:15
@github-actions github-actions bot removed the partialCIBuild Perform Partial CI Build label Jan 28, 2025
@hakermi
Copy link
Member Author

hakermi commented Jan 28, 2025

Thanks for the quick fixes. Can you please add the new I18N file in

social/crowdin.yml

Lines 561 to 577 in 3be63b0

{
"source": "/webapp/src/main/resources/locale/portlet/SpaceTemplatesManagement_en.properties",
"translation": "%original_path%/%file_name%!_%locale_with_underscore%.%file_extension%",
"translation_replace": {
"_en!": "","ar_SA": "ar","ar_OM": "aro","az_AZ": "az","ca_ES": "ca","ceb_PH": "ceb",
"co_FR": "co","cs_CZ": "cs","de_DE": "de","el_GR": "el","en_US": "en","es_ES": "es_ES","eu_ES": "eu","fa_IR": "fa",
"fi_FI": "fi","fil_PH": "fil","fr_FR": "fr","hi_IN": "hi","hu_HU": "hu","id_ID": "id","it_IT": "it","ja_JP": "ja",
"kab_KAB": "kab","ko_KR": "ko","lt_LT": "lt","ms_MY": "ms","nl_NL": "nl","no_NO": "no","pcm_NG": "pcm","pl_PL": "pl",
"pt_BR": "pt_BR","pt_PT": "pt_PT","ro_RO": "ro","ru_RU": "ru","sk_SK": "sk","sl_SI": "sl","sq_AL": "sq",
"sv_SE": "sv_SE","th_TH": "th","tl_PH": "tl","tr_TR": "tr","uk_UA": "uk","ur_IN": "ur_IN","vi_VN": "vi",
"zh_CN": "zh_CN","zh_TW": "zh_TW",
},
"dest": "hub/social/webapp/SpaceTemplatesManagement.properties",
"update_option": "update_as_unapproved",
"escape_special_characters": 0,
"escape_quotes": 0,
},

in order to allow Synchronization with Crowdin after merging on Develop.

Done

Copy link

Copy link
Member

@boubaker boubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @hakermi . I let @rdenarie review

@hakermi hakermi merged commit 46ad73c into feature/experience Jan 28, 2025
8 checks passed
@hakermi hakermi deleted the TASK-8221 branch January 28, 2025 13:37
exo-swf pushed a commit that referenced this pull request Jan 29, 2025
hakermi added a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants