Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting network device desired state to be pulled from host adminstate flags #9

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

heyvister1
Copy link
Contributor

@heyvister1 heyvister1 commented Nov 7, 2024

Applying network device admin state according it device's flags and not operstate
since operstate is not reflecting device's desired state

changing:

  • dev_operstate --> dev_adminstate
  • vf_operstate --> vf_adminstate
  • representor_operstate --> representor_adminstate
+ '[' '' == switchdev ']'
+ exec_cmd 'ip link set dev ibp3s0f0 up'
+ debug_print 'Executing command: ip link set dev ibp3s0f0 up'
+ true
+ timestamp_print Executing command: ip link set dev ibp3s0f0 up
++ date +%d-%b-%y_%H:%M:%S
+ date_time_stamp=07-Nov-24_13:17:18
+ msg='[07-Nov-24_13:17:18] Executing command: ip link set dev ibp3s0f0 up'
+ echo '[07-Nov-24_13:17:18] Executing command: ip link set dev ibp3s0f0 up'
+ tee -a /tmp/entrypoint_debug_cmds.log
[07-Nov-24_13:17:18] Executing command: ip link set dev ibp3s0f0 up
++ eval 'ip link set dev ibp3s0f0 up'
+++ ip link set dev ibp3s0f0 up
+ output=

+ exit_code=0

@heyvister1
Copy link
Contributor Author

/retest

@rollandf
Copy link
Member

rollandf commented Nov 7, 2024

Ignore the lint for now, need to fix the issues that were there before.

@heyvister1 heyvister1 force-pushed the fix-mofed-set-admin-state branch from c91e016 to c4297ff Compare November 7, 2024 14:19
…ad of using operstate

since operstate is not reflecting device's desired state

Signed-off-by: Ido Heyvi <[email protected]>
@heyvister1 heyvister1 force-pushed the fix-mofed-set-admin-state branch from c4297ff to 4dd4d3c Compare November 7, 2024 14:28
@heyvister1 heyvister1 changed the title Fixing network device desired state to be pulled from host device flags Setting network device desired state to be pulled from host adminstate flags Nov 7, 2024
Copy link

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e0ne e0ne merged commit 336aa1f into Mellanox:main Nov 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants