hw-mgmt: scripts: Delete psuN_i2c_bus files when PSUs are plugged out #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files are generated when PSUs are detected on I2C bus. However they are not removed when PSUs are plugged out. This makes it difficult to differentiate between real and dummy PSUs since dummy PSUs are not visible on I2C. Signed-off-by: Felix Radensky <[email protected]>
felixradensky
requested review from
sholeksandr,
ciju-nvidia,
mshych and
vadimp-nvidia
as code owners
|
RERUN |
ciju-nvidia
reviewed
Nov 26, 2024
| @@ -1419,6 +1419,9 @@ else | |||
| rm -f "$config_path"/"$psu_name"_power_slope | |||
| rm -f "$config_path"/"$psu_name"_power_capacity | |||
| fi | |||
| if [ -e "$config_path"/"$psu_name"_i2c_bus ]; then | |||
| rm -f "$config_path"/"$psu_name"_i2c_bus | |||
| fi | |||
There was a problem hiding this comment.
-
Isn't it better to retain the config files to know the platform specific i2c bus number for PSUs?
PSU presence is anyway available in the events folder. -
Are we sure that NOSs are not using this config attribute?
There was a problem hiding this comment.
The psuN_i2c_bus files are generated when PSU is detected, so they exist only for real PSUs, not for all possible PSUs. Using the same logic, they should be deleted when PSU is removed, just like all other files related to this PSU are deleted. NVOS will check the existence of these files to know if PSU is real or dummy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files are generated when PSUs are detected on I2C bus. However they are not removed when PSUs are plugged out. This makes it difficult to differentiate between real and dummy PSUs since dummy PSUs are not visible on I2C.