issue: 2336523 Return RX pbufs to cq_mgr instead of global pool #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-ivanov
reviewed
Oct 28, 2020
| temp->rx.timestamps.hw.tv_nsec = 0; | ||
| temp->rx.timestamps.hw.tv_sec = 0; | ||
| temp->rx.hw_raw_timestamp = 0; | ||
| memset(&temp->rx, 0, sizeof(temp->rx)); |
There was a problem hiding this comment.
please do the same change in all identical places (for example: ring_tap) or avoid change
igor-ivanov
reviewed
Oct 28, 2020
src/vma/dev/ring_simple.cpp
Outdated
| void ring_simple::mem_buf_rx_release(mem_buf_desc_t* p_mem_buf_desc) | ||
| { | ||
| /* Call this method under m_lock_ring_rx lock */ | ||
| m_p_cq_mgr_rx->reclaim_recv_buffers(p_mem_buf_desc); |
There was a problem hiding this comment.
please consider using reclaim_recv_buffers_no_lock() call
igor-ivanov
reviewed
Oct 28, 2020
| @@ -143,6 +143,8 @@ inline void sockinfo_tcp::init_pbuf_custom(mem_buf_desc_t *p_desc) | |||
| p_desc->lwip_pbuf.pbuf.type = PBUF_REF; | |||
| p_desc->lwip_pbuf.pbuf.next = NULL; | |||
| p_desc->lwip_pbuf.pbuf.payload = (u8_t *)p_desc->p_buffer + p_desc->rx.tcp.n_transport_header_len; | |||
| /* Override default free function to return rx pbuf to the CQ cache */ | |||
| p_desc->lwip_pbuf.custom_free_function = sockinfo_tcp::tcp_rx_pbuf_free; | |||
There was a problem hiding this comment.
I prefer to explicitly change pbuf_free() with 'tcp_rx_pbuf_free()' and use the same change as was done for tcp_rx_pbuf_free(). It is more save for future.
The reason: custom_free_function callback is common for tx and rx flow and it is easy to do mistake in future change
pasis
force-pushed
the
pr/issue-2336523
branch
from
e75c66f
to
ee994ca
Compare
|
Rebased on top of vNext and updated with the latest version. |
Signed-off-by: Igor Ivanov <[email protected]>
Signed-off-by: Igor Ivanov <[email protected]>
m_recv_rings is introduced to control rx flow. m_recv_rings can have the same size as m_bond_rings in case every simple ring should process income traffic or less if RoCE LAG device is used (for RoCE LAG device single simple ring should handle rx). Signed-off-by: Igor Ivanov <[email protected]>
1. The register storage class specifier is deprecated in C++11 2. Disable -Wno-free-nonheap-object diagnostic that looks as incorrect for gcc-11 Signed-off-by: Igor Ivanov <[email protected]>
drain_and_proccess() is mainly called in following cases as Internal thread: Frequency of real polling can be controlled by VMA_PROGRESS_ENGINE_INTERVAL and VMA_PROGRESS_ENGINE_WCE_MAX. socketxtreme: User does socketxtreme_poll() Cleanup: QP down logic to release rx buffers should force polling to do this. Not null argument indicates one. Signed-off-by: Igor Ivanov <[email protected]>
|
@pasis please update with addirional fix https://github.com/Mellanox-lab/libvma-pro/pull/22/commits/4ae9b6e7a49bda85d18f00cb5d10a66ff861342f |
ring_bond passes lkey query to one of its child rings. However, get_tx_lkey() uses m_bond_rings and send_lwip_buffer() uses m_xmit_rings to choose the child ring. This inconsistency can lead to a situation when lkey is set from a wrong ring. Use m_xmit_rings in get_tx_lkey(). Signed-off-by: Dmytro Podgornyi <[email protected]>
Both team and bonding Master interface has IFF_MASTER flag bit set. However, linux sys files, such as BONDING_MODE_PARAM_FILE, are used to check bonding interface. The linux 'team' kernel module does not create those files as 'bonding' module. In other words, 'bonding' interface verify does not work for 'team' interface, so skip 'team' interface when check 'bonding'. Otherwise, we will have significant performance issues for UDP traffic over 'team' interface. Fixes: ee0a1b9 ("issue: 2233904 Check bonding device using netlink") Signed-off-by: Honggang Li <[email protected]> Reviewed-by: Igor Ivanov <[email protected]>
Suppress an implicit-fallthrough warning Suppress stringop-truncation warning Fix 'memset' usage Signed-off-by: Honggang Li <[email protected]> Reviewed-by: Igor Ivanov <[email protected]>
TIMESTAMP option must be included in keepalives and zero window probes. However, VMA ignores the option for these segments. Add TIMESTAMP support in the same way as during sending an empty ACK. TODO: Reduce copy-paste in the functions that send single pbufs. Signed-off-by: Dmytro Podgornyi <[email protected]>
When we add an item to a non-empty m_reg_action_q, we don't have to wakeup the internal thread, because it will handle the item. As result, we reduce number of epoll_ctl() calls. Signed-off-by: Dmytro Podgornyi <[email protected]>
Access to m_is_sleeping must be serialized. Otherwise, this leads to a race and respectful entity may not be awaken when requested. Signed-off-by: Dmytro Podgornyi <[email protected]>
The buildroot should not be deleted at start of %install https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections Signed-off-by: Igor Ivanov <[email protected]>
Remove %{use_extralib} macro
%make_build is a macro that is available starting rpm-4.12.
It is equivalent to `make %{?_smp_mflags}`.
Signed-off-by: Igor Ivanov <[email protected]>
RDMA communications require that physical memory in the computer be pinned. Pinning memory is normally a very privileged operation. In order to allow users other than root to run large RDMA applications, it will likely be necessary to increase the amount of memory that non-root users are allowed to pin in the system. This is done by adding a file in the /etc/security/limits.d/ directory. It can be done by an administrator of system for user/group that use libvma. Signed-off-by: Igor Ivanov <[email protected]>
This changes are done to be aligned with last Fedora requirements. Signed-off-by: Igor Ivanov <[email protected]>
pasis
force-pushed
the
pr/issue-2336523
branch
from
ee994ca
to
bf78b20
Compare
Global buffer_pool lock leads to a lock contention in multi-threaded applications. We can mitigate it by using ring per core and returning pbufs to respective cq_mgr cache. Signed-off-by: Dmytro Podgornyi <[email protected]>
igor-ivanov
approved these changes
Mar 4, 2021
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global buffer_pool lock leads to a lock contention in multi-threaded applications. We can mitigate it by using ring per core and returning pbufs to respective cq_mgr cache.