task: Sync master from upstream #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
SriovNetworkNodePolicySpec - Bridge field added SriovNetworkNodeStateSpec - Bridges field added SriovNetworkNodeStateStatus - Bridges field added VirtualFunction - RepresentroName field added Signed-off-by: Yury Kulazhenkov <[email protected]>
[software-bridges 1/x] Update API to support automatic bridge creation
Signed-off-by: amaslennikov <[email protected]>
Add support for reporting VF representor name when the NIC is in switchev mode Signed-off-by: Yury Kulazhenkov <[email protected]>
Signed-off-by: Yury Kulazhenkov <[email protected]>
Today, we are missing 2 checks on settings that sriov netop is configuring: * PF is up * GUID is set Without checking for these 2, we risk that changes made by the user directly to the system are not reconciled by the netop leaving the system in a bad state. This commit is adding those checks. Signed-off-by: Vasilis Remmas <[email protected]>
Signed-off-by: Vasilis Remmas <[email protected]>
Add more checks on generic plugin to discover discrepancies from the desired state
Signed-off-by: Andrea Panattoni <[email protected]>
Add a make rule to verify `make manifests` has been run after every change to the CRDs. Signed-off-by: Andrea Panattoni <[email protected]>
When the MTU set in the SRIOV Network Node Policy is lower than the actual MTU of the PF, it triggers the reconcile loop for the Node state indefinitely, preventing the configuration from completing. Signed-off-by: amaslennikov <[email protected]>
Update `config/` folder
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Add 'IB VF GUID Configuration' design doc
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Add mtu functional test
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Fix issue preventing lowering of PF's MTU
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Since we always deploy both mutation and validating webhooks there is no need to validate policy for InfiniBand and RDMA enabled because mutating webhook will wet 'isRdma' flag to 'true' for InfiniBand'.
- add workflow to update helm chart and push to ghcr.io oc registry - add chart update script to edit chart values for a specific release - add chart push script to package and push helm chart - add makefile targets to install pre-req and invoke scripts above Signed-off-by: adrianc <[email protected]>
this will allow to publish a separate package for the chart named: sriov-network-operator-chart eg: ghcr.io/k8snetworkplumbingwg/sriov-network-operator-chart Signed-off-by: adrianc <[email protected]>
Update machine config operator to remove dependency on goproxy. Signed-off-by: Salvatore Daniele <[email protected]>
Signed-off-by: Salvatore Daniele <[email protected]>
Due to updating the machine config operator, we removed an indirect dependency on github.com/golang/glog. This package provides an init() method which sets a number of flags that we expect to be present [1]. To ensure compatability with the updates, we can explicitly add these flags with the klog.init() method [2]. It is better to include packages that are required to keep the API consistent explicitly. [1] https://github.com/golang/glog/blob/424d2337a5299a465c8a8228fc3ba4b1c28337a2/glog.go#L398-L404 [2] https://github.com/kubernetes/klog#:~:text=Use%20klog.InitFlags(nil)%20explicitly%20for%20initializing%20global%20flags%20as%20we%20no%20longer%20use%20init()%20method%20to%20register%20the%20flags Signed-off-by: Salvatore Daniele <[email protected]>
Signed-off-by: Balazs Nemeth <[email protected]>
Bump go version to 1.22
[metrics 1/x] Support `sriov-network-metrics-exporter`
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Update ovs-cni image path to use NPWG registry
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
[software-bridges 2/x] report VF representor name in SriovNetworkNodeState.Status field
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
…es/github.com/hashicorp/go-retryablehttp-0.7.7 Bump github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Merge issue coming from - #690 - #587 Signed-off-by: Andrea Panattoni <[email protected]>
Fix `undefined: pciAddr`
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Using `helm` to deploy the operator in vanilla k8s CI lanes helps avoid error in helm charts changes. Instead of adding a new helm e2e lane (as it would increase the CI load), we can keep the already in place lanes as: - OpenShift: use the `hack/deploy-setup.sh` script - K8s: use helm chart Signed-off-by: Andrea Panattoni <[email protected]>
Signed-off-by: Andrea Panattoni <[email protected]>
Webhook resources (`ValidatingWebhookConfiguration` and `MutatingWebhookConfiguration`) in OpenShift are configured with `service.beta.openshift.io/inject-cabundle` in a way that a third component fills the ClientConfig.CABundle field of the webhook. When reconciling webhooks, do not override the field and avoid a flakiness, as there might be a time slot in which the API server is not configured with a valid client certificate: ``` Error from server (InternalError): error when creating "policies": Internal error occurred: failed calling webhook "operator-webhook.sriovnetwork.openshift.io": failed to call webhook: Post "https://operator-webhook-service.openshift-sriov-network-operator.svc:443/mutating-custom-resource?timeout=10s": tls: failed to verify certificate: x509: certificate signed by unknown authority ``` The same behavior also happens when using CertManager Refs: - https://docs.openshift.com/container-platform/4.15/security/certificates/service-serving-certificate.html - https://issues.redhat.com/browse/OCPBUGS-32139 - https://cert-manager.io/docs/concepts/ca-injector/ Signed-off-by: Andrea Panattoni <[email protected]>
If a Virtual Function is configured with a DPDK driver (e.g. `vfio-pci`) and it is not referred by any SriovNetworkNodePolicy, `NeedToUpdateSriov` function must not trigger a reconfiguration. This may happen if a PF is configured by multiple policies (via PF partitioning) and a policy is deleted by the user. In these cases, the VF is not reconfigured [1] and a drain loop is started The same logic applies to VDPA devices. refs: [1] https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/5f3c4e903f789aa177fe54686efd6c18576b7ab1/pkg/host/internal/sriov/sriov.go#L457 Signed-off-by: Andrea Panattoni <[email protected]>
fix: regenerate API pkg with controller-gen 0.14.0 and go 1.22
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Avoid reconciling field `Webhook.ClientConfig.CABundle`
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
we need to be consistent with the policy order Signed-off-by: Sebastian Sch <[email protected]>
add sort for the policy on the sriovOperatorConfig controller
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
e2e: Use `helm` to deploy on k8s cluster
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Remove webhook validation for InfiniBand and RDMA
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Avoid reconfiguring unmentioned DPDK VFs
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by Mellanox/sriov-network-operator CI (sync-fork job).