Feature #4151551: TFS plugin refactor streamer.py file #278
+758
−741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
1. Create a seperate file for each class located in the streamer.py file
2. Remove the data fetching in the Prometheus format
3. Remove the inline args usage from the flow
4. Break the UFMTelemetryStreaming class into more granular classes
Why ?
https://redmine.mellanox.com/issues/4151551.
Remove unused functionality and break large file into smaller ones.
How ?
_
Break the UFMTelemetryStreaming class into three classes:
_
Testing ?
Regression tests for TFS
Special triggers
Use the following phrases as comments to trigger different runs
bot:retest
rerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgrade
run additional update tests