issue:4273572 Implement NDT plugin upgrade #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextabachnik
requested review from
kobibar,
kedeme,
ananalaghbar,
atolikin94 and
boazhaim
shmufeld
reviewed
Feb 9, 2025
|
|
||
|
|
||
| def createCfgLine(key, value): | ||
| line = "%s=%s\n" % (key, value) |
There was a problem hiding this comment.
Suggested change
| line = "%s=%s\n" % (key, value) | |
| line = "%s = %s\n" % (key, value) |
| return line | ||
|
|
||
|
|
||
| help_keys = ('-h', '--h', '-help', '--help') |
There was a problem hiding this comment.
consider using argparse instead.
| NEW_CONF_FILE=/opt/ufm/ufm_plugin_ndt/ndt.conf | ||
| TMP_CONF_FILE=/tmp/ndt_tmp.conf | ||
|
|
||
| python3 /opt/ufm/ufm_plugin_ndt/cfg_files_merge.py "${NEW_CONF_FILE}" "${CURRENT_CONF_FILE}" "${TMP_CONF_FILE}" |
There was a problem hiding this comment.
python3?
not UFM's python?
kedeme
reviewed
Feb 10, 2025
| @@ -0,0 +1,114 @@ | |||
| """ | |||
There was a problem hiding this comment.
already discussed - we said that we want to copy this merger module from external shared location for all the plugins (not a copy for each plugin) - can you please handle that?
There was a problem hiding this comment.
implementing and testing
shmufeld
approved these changes
Feb 10, 2025
kedeme
approved these changes
Feb 10, 2025
issue:4274215 support duplicated node description report in case no other errors detected (bug fix) Signed-off-by: Alex Tabachnik <[email protected]>
Signed-off-by: Alex Tabachnik <[email protected]>
alextabachnik
force-pushed
the
issue/4273572_ndt_plugin_upgrade
branch
from
07831ec to
957c948
Compare
|
bot:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:4274215 support duplicated node description report in case no other errors detected (bug fix)
What
implement upgrade.sh script that could be used for upgrade flow if need
handle option for merger report when node description duplication error is an only error in report (buf fix bug )
Why ?
Fix a bug and add functionality (upgrade)
How ?
Implemented empty upgrade.sh script as this script required by upgrade flow.
Added functionality for duplicated node description report if it is the only error in fabric
Testing ?
Tested manually
Special triggers
Use the following phrases as comments to trigger different runs
bot:retestrerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgraderun additional update tests