feat: Accept an app key + refresh token for Dropbox

MeltanoLabs · Sep 6, 2024 · acaa5f8 · acaa5f8
1 parent 09d3256
commit acaa5f8
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 16 deletions.
diff --git a/.github/workflows/ci_workflow.yml b/.github/workflows/ci_workflow.yml
@@ -14,7 +14,6 @@ on:
     - pyproject.toml
     - tox.ini
   pull_request:
-    branches: [main]
     paths:
     - .github/workflows/ci_workflow.yml
     - .github/workflows/constraints.txt

diff --git a/README.md b/README.md
@@ -93,20 +93,18 @@ Optionally, the files definition can be provided by an external json file:
 
 #### FTP
 
-| Setting      | Required | Default | Description             |
-| :----------- | :------- | :------ | :---------------------- |
-| ftp          | False    | None    | FTP connection settings |
-| ftp.host     | True     | None    | FTP server host         |
-| ftp.port     | False    | 21      | FTP server port         |
-| ftp.username | False    | None    | FTP username            |
-| ftp.password | False    | None    | FTP password            |
-| ftp.encoding | False    | utf-8   | FTP server encoding     |
+| Setting      | Required | Default | Description         |
+| :----------- | :------- | :------ | :------------------ |
+| ftp.host     | True     | None    | FTP server host     |
+| ftp.port     | False    | 21      | FTP server port     |
+| ftp.username | False    | None    | FTP username        |
+| ftp.password | False    | None    | FTP password        |
+| ftp.encoding | False    | utf-8   | FTP server encoding |
 
 #### GitHub
 
 | Setting         | Required | Default | Description                                                 |
 | :-------------- | :------- | :------ | :---------------------------------------------------------- |
-| github          | False    | None    | GitHub connection settings                                  |
 | github.org      | True     | None    | GitHub organization or user where the repository is located |
 | github.repo     | True     | None    | GitHub repository                                           |
 | github.username | False    | None    | GitHub username                                             |
@@ -141,10 +139,10 @@ Optionally, the files definition can be provided by an external json file:
 
 #### Dropbox
 
-| Setting       | Required | Default | Description                 |
-| :------------ | :------- | :------ | :-------------------------- |
-| dropbox       | False    | None    | Dropbox connection settings |
-| dropbox.token | True     | None    | Dropbox token               |
+| Setting               | Required | Default | Description           |
+| :-------------------- | :------- | :------ | :-------------------- |
+| dropbox.app_key       | True     | None    | Dropbox App key       |
+| dropbox.refresh_token | True     | None    | Dropbox refresh token |
 
 The token needs the `files.content.read` scope:
 

diff --git a/tap_csv/filesystem_config.py b/tap_csv/filesystem_config.py
@@ -76,11 +76,18 @@
     "dropbox",
     th.ObjectType(
         th.Property(
-            "token",
+            "app_key",
+            th.StringType,
+            secret=True,
+            required=True,
+            description="Dropbox App key",
+        ),
+        th.Property(
+            "refresh_token",
             th.StringType,
             secret=True,
             required=True,
-            description="Dropbox token",
+            description="Dropbox refresh token",
         ),
     ),
     description="Dropbox connection settings",