Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove access token thats unnecessary (UA) #160

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

pnadolny13
Copy link
Collaborator

This makes the same changes as #159 but on the UA branch.

@pnadolny13 pnadolny13 changed the base branch from main to main_deprecated_ua March 11, 2024 20:13
@pnadolny13
Copy link
Collaborator Author

@edgarrmondragon ever seen this before https://github.com/MeltanoLabs/tap-google-analytics/actions/runs/8239172498/job/22533964877?pr=160? I reran it a few times in case it was flaky but no luck. It looks like its doing exactly what #159 does and that one passed. I'm not sure how to get at those log files that it mentions.

@edgarrmondragon
Copy link
Member

@edgarrmondragon ever seen this before https://github.com/MeltanoLabs/tap-google-analytics/actions/runs/8239172498/job/22533964877?pr=160? I reran it a few times in case it was flaky but no luck. It looks like its doing exactly what #159 does and that one passed. I'm not sure how to get at those log files that it mentions.

@pnadolny13 #161 should fix it

Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pnadolny13 pnadolny13 merged commit 2cb6d2c into main_deprecated_ua Mar 12, 2024
8 of 9 checks passed
@pnadolny13 pnadolny13 deleted the ua_branch_remove_access_token branch March 12, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants