refactor: Optimise metadata discovery for large databases #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmeneghello
force-pushed
the
main
branch
2 times, most recently
from
c641747 to
9109819
Compare
edgarrmondragon
changed the title
|
Fixed those and the issues from the CI run. |
edgarrmondragon
approved these changes
Nov 5, 2024
edgarrmondragon
added a commit
that referenced
this pull request
Nov 7, 2024
3 tasks
| inspected = sa.inspect(engine) | ||
| for schema_name in self.get_schema_names(engine, inspected): | ||
| # Use get_multi_* data here instead of pulling per-table | ||
| table_data = inspected.get_multi_columns(schema=schema_name) |
There was a problem hiding this comment.
This ignores views, thus the regression. See https://github.com/meltano/sdk/pull/2793/files#r1867006461.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides the SDK functions to instead use the
get_multi_*functions from SQLAlchemy Inspector. On our database of ~120 tables, this reduces the discovery runtime from 10-12 minutes to about 30 seconds.