Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#370] added pressing Enter to create a room #384

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

2or4spaces
Copy link
Contributor

Added a new handleCreateRoomPressEnter which creates a new room when pressing Enter

@github-actions
Copy link

github-actions bot commented Jul 21, 2023

Coverage report for apps/ligretto-gameplay-backend

St.
Category Percentage Covered / Total
🔴 Statements 48.63% 373/767
🔴 Branches 24.53% 26/106
🔴 Functions 26.07% 55/211
🔴 Lines 46.27% 310/670

Test suite run success

12 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 9ba3cd4

@2or4spaces 2or4spaces self-assigned this Jul 21, 2023
@2or4spaces
Copy link
Contributor Author

  1. handleCreateRoomPressEnter переименовал в handleCreateRoomKeyDown
  2. Перенес проверку имени комнаты в handleCreateRoom. Также добавил проверку на validationErrors. Он регуляркой ограничивает символы, которые могут быть именем комнаты (запрещены - + . , и т.д.), а также ставит ограничение в количество символов, равное 20. Иначе нажатием на Enter можно создать комнату, например, с именем "+", но кнопка Create при этом недоступна.

@Themezv Themezv added this pull request to the merge queue Jul 28, 2023
Merged via the queue into master with commit 23d6bf0 Jul 28, 2023
5 checks passed
@Themezv Themezv deleted the feature/370-Ligretto_create_game_on_enter_press branch July 28, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants