[#170]: interfaces creation #467
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 48.35% (-1.45% 🔻) |
352/728 |
| 🔴 | Branches | 25.24% | 26/103 |
| 🔴 | Functions | 26.7% | 55/206 |
| 🔴 | Lines | 45.73% (-1.75% 🔻) |
289/632 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / game.service.ts |
43.96% (-1.21% 🔻) |
31.25% | 27.59% | 45.12% (-1.31% 🔻) |
| 🔴 | ... / gameplay-controller.ts |
22.73% (-3.36% 🔻) |
0% | 0% | 19.05% (-3.68% 🔻) |
| 🟢 | ... / games-controller.ts |
81.82% (-0.53% 🔻) |
81.25% | 58.33% | 81.25% (-0.57% 🔻) |
| 🔴 | ... / gameplay.ts |
17.02% (-4.98% 🔻) |
0% | 0% | 13.33% (-5.42% 🔻) |
| 🔴 | ... / handler.ts |
34.38% (-7.29% 🔻) |
0% | 0% | 31.03% (-8.36% 🔻) |
| 🟢 | ... / game.repo.ts |
86.21% (-0.46% 🔻) |
100% | 81.25% | 85.71% (-0.65% 🔻) |
| 🔴 | ... / playground.service.ts |
21.62% (-2.06% 🔻) |
0% | 0% | 17.65% (-2.35% 🔻) |
| 🔴 | ... / playground.repo.ts |
28.57% (-3.25% 🔻) |
100% | 0% | 23.53% (-4.25% 🔻) |
| 🔴 | ... / player.repo.ts |
13.95% (-1.96% 🔻) |
0% | 0% | 12.9% (-2.72% 🔻) |
| 🔴 | ... / player.service.ts |
14.29% (-1.71% 🔻) |
0% | 0% | 11.9% (-2.05% 🔻) |
| 🟡 | ... / user.repo.ts |
66.67% (-1.52% 🔻) |
0% | 50% | 64.71% (-1.96% 🔻) |
| 🔴 | ... / user.service.ts |
50% (-2.94% 🔻) |
0% | 40% | 46.15% (-3.85% 🔻) |
| 🔴 | ... / bot-controller.ts |
56.25% (-2.57% 🔻) |
100% | 0% | 50% (-3.33% 🔻) |
Test suite run success
12 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 3df9a2f
Themezv
reviewed
Mar 20, 2024
| handleMessage: (socket: Socket, action: AnyAction) => void | ||
| } | ||
|
|
||
| // XXX: Is there the necessity of IController |
There was a problem hiding this comment.
I think no
Lets try to remove @injectable()
Themezv
reviewed
Mar 20, 2024
|
|
||
| connect(socketServer: Server) { | ||
| socketServer.use(authMiddleware).on('connection', socket => this.connectionHandler(socket)) | ||
| } | ||
|
|
||
| public async connectionHandler(socket: Socket): Promise<void> { | ||
| // XXX: why is this method public? It is used only inside itself |
Themezv
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#170
Создал интерфейсы для классов, чтобы реализовать ioc
Пара моментов, на которые стоит обратить внимание:
XXX. Там я задал уточняющие вопросы.