Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frozensuffix #117

Merged
merged 7 commits into from
Jul 7, 2019
Merged

Frozensuffix #117

merged 7 commits into from
Jul 7, 2019

Conversation

WhiteNervosa
Copy link
Contributor

@WhiteNervosa WhiteNervosa commented Jul 6, 2019

Frozen suffix appears:
VrItQXD

Hopefully checking off a box #82

@jbpratt jbpratt requested review from jbpratt and xDashh July 6, 2019 15:41
assets/chat/js/const.js Outdated Show resolved Hide resolved
Copy link
Member

@xDashh xDashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature-Approve

  • Did someone test with wide/irregular emotes?

@WhiteNervosa
Copy link
Contributor Author

Feature-Approve

  • Did someone test with wide/irregular emotes?

Yes, Xymos did here (which I should have done, sooner) and the only one that appears to have slight clipping issues is AngelThump #114

@xDashh
Copy link
Member

xDashh commented Jul 7, 2019

Feature-Approve

  • Did someone test with wide/irregular emotes?

Yes, Xymos did here (which I should have done, sooner) and the only one that appears to have slight clipping issues is AngelThump #114

That was only regarding :wide, right? I meant regarding :frozen, i.e. is the freeze-block on the left wing of e.g. Angelthump or properly in the middle? (or does it minimize the entire emote into the ice?)

@WhiteNervosa
Copy link
Contributor Author

OH - pardon, I get these mixed up too easy.

It works well with ResidentSleeper but that is only 52px, as it also shrinks the emotes a little bit. I can see a couple outliers doing poorly with it.

@jbpratt jbpratt merged commit 09ca125 into MemeLabs:master Jul 7, 2019
@jbpratt
Copy link
Member

jbpratt commented Jul 7, 2019

Merged, thank you for the feature!

@xDashh
Copy link
Member

xDashh commented Jul 7, 2019

Please note #121

SmCTwelve pushed a commit to SmCTwelve/chat-gui that referenced this pull request Jul 8, 2019
Frozen modifier implemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants