Skip to content

Commit

Permalink
#1 - Todo organization
Browse files Browse the repository at this point in the history 
- updating todos
  • Loading branch information
@kuzya-zz
kuzya-zz committed May 30, 2020
1 parent cdc360b commit cad232e
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 6 deletions.
7 changes: 4 additions & 3 deletions packages/infra-bus/lib/InfraBus.mjs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,10 @@ export class InfraBus extends Bus {
}

async subscribe(messages, command) {
// TODO: #1 Add separation by message pattern, like router url
// leave a wat to use topic original API + expose Variables
// constructor so subscriber no need to import camunda package
/**
* @todo #1:45m/DEV Add separation by message pattern, like router url
* leave a wat to use topic original API + expose Variables
*/

const delegate = new TopicDelegateCommand(command, this.#log)
return this.#client.subscribe(messages, async topic => {
Expand Down
7 changes: 5 additions & 2 deletions packages/infra-execution/lib/ProcessExecution.mjs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,11 @@ export class ProcessExecution extends LifecycleExecution {
attachAndStart() {
this.#process.on('SIGTERM', this.#gracefulShutdown);
this.#process.on('SIGINT', this.#gracefulShutdown);

// TODO: #1 Add Proper exit for pino 'http://getpino.io/#/docs/help?id=exit-logging'
/**
* @todo #1:30m/DEV Exit logging Pino
* follow 'http://getpino.io/#/docs/help?id=exit-logging'
*
*/
this.#process.on('unhandledRejection', error => {
this.#logger.fatal({
type : 'UnhandledRejection',
Expand Down
7 changes: 6 additions & 1 deletion packages/infra-logger/lib/InfraLogger.mjs
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import pino from 'pino'
import {Logger} from "@mentorioum/core-infra";

// TODO: #1 Experiment with sending logs to https://github.com/pinojs/pino-elasticsearch
/**
* @todo #1:45m/DEV Experimenting to send logs in elastic search
* look in https://github.com/pinojs/pino-elasticsearch,
* write you findings
*
*/

export class InfraLogger extends Logger {

Expand Down

8 comments on commit cad232e

@0pdd
Copy link

@0pdd 0pdd commented on cad232e May 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 1-2f4fc159 discovered in apps/github-sync/lib/GithubSyncLifecycle.mjs and submitted as #2. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link

@0pdd 0pdd commented on cad232e May 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 1-9247272c discovered in apps/github-sync/lib/notification/NotificationFetchNewCommand.mjs and submitted as #3. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link

@0pdd 0pdd commented on cad232e May 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 1-5bf5d879 discovered in apps/github-sync/lib/GithubSyncLifecycle.test.mjs and submitted as #4. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link

@0pdd 0pdd commented on cad232e May 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 1-7ac8819a discovered in packages/access-github/lib/notification/GithubNotificationAccess.mjs and submitted as #5. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link

@0pdd 0pdd commented on cad232e May 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 1-f105dc40 discovered in packages/infra-bus/lib/InfraBus.test.mjs and submitted as #6. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link

@0pdd 0pdd commented on cad232e May 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 1-78ea7b97 discovered in packages/infra-bus/lib/InfraBus.mjs and submitted as #7. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link

@0pdd 0pdd commented on cad232e May 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 1-a3f260bb discovered in packages/infra-execution/lib/ProcessExecution.mjs and submitted as #8. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link

@0pdd 0pdd commented on cad232e May 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 1-1c542a2b discovered in packages/infra-logger/lib/InfraLogger.mjs and submitted as #9. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

Please sign in to comment.