Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add {stats} to Imports #325

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Add {stats} to Imports #325

merged 1 commit into from
Jan 25, 2024

Conversation

jdblischak
Copy link
Collaborator

I noticed that {stats} is in NAMESPACE but not DESCRIPTION

gsDesign2/NAMESPACE

Lines 80 to 83 in 187edf3

importFrom(stats,pnorm)
importFrom(stats,qnorm)
importFrom(stats,stepfun)
importFrom(stats,uniroot)

@jdblischak jdblischak requested a review from nanxstats January 25, 2024 16:31
@jdblischak jdblischak self-assigned this Jan 25, 2024
nanxstats
nanxstats approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding - always good to be consistent.

@nanxstats nanxstats merged commit 71f65b6 into Merck:main Jan 25, 2024
8 checks passed
@jdblischak jdblischak deleted the import-stats branch January 25, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanxstats nanxstats nanxstats approved these changes

Assignees

@jdblischak jdblischak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdblischak @nanxstats