Add an option to use cabal-install for the build
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbrice
reviewed
Mar 25, 2024
Comment on lines
-539
to
+547
| export GHC_PACKAGE_PATH="$packageConfDir:" | ||
| ${lib.optionalString (!useCabalInstall) ''export GHC_PACKAGE_PATH="$packageConfDir:"''} |
There was a problem hiding this comment.
Wouldn't this env var simply be ignored if using cabal-install? Why put it behind a switch?
There was a problem hiding this comment.
The cabal V2 CLI complains about it if you set it. It will tell you to instead set --package-db to the same value (which the Nix build already does)
|
I'm still not sure if I should merge this because it doesn't seem to fix the original build performance problem I was trying to solve. I'm still debugging further |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
useCabalInstalloption to the Haskell builder which lets you use thecabal(v2) command-line interface instead of the./Setup(v1) command-line interface.This is a hash-preserving change for Haskell packages that don't use this flag.