asserting manager is not null when setting

MerginMaps · Nov 13, 2024 · 965c176 · 965c176 · inputapp-bot · Nov 13, 2024
1 parent 216a6b9
commit 965c176
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/core/merginapi.cpp b/core/merginapi.cpp
@@ -3972,6 +3972,9 @@ bool MerginApi::isRetryableNetworkError( QNetworkReply *reply )
 
 void MerginApi::setNetworkManager( QNetworkAccessManager *manager )
 {
+  if ( !manager )
+    return;
+
   if ( mManager == manager )
     return;
 

diff --git a/core/merginapi.h b/core/merginapi.h
@@ -584,6 +584,7 @@ class MerginApi: public QObject
 
     /**
      * Sets the network manager to be used for Mergin API requests
+     * Function will return early if manager is null.
      */
     void setNetworkManager( QNetworkAccessManager *manager );
-Original file line number
+Diff line change
@@ Expand Up @@
     void MerginApi::setNetworkManager( QNetworkAccessManager *manager )
     {
+      if ( !manager )
+        return;
       if ( mManager == manager )
         return;
@@ Expand Down @@