Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert symbol size #2854

Merged
merged 1 commit into from
Oct 13, 2023
Merged

revert symbol size #2854

merged 1 commit into from
Oct 13, 2023

Conversation

PeterPetrik
Copy link
Contributor

fix #2853

@PeterPetrik PeterPetrik added the ready-for-testing Ready to be tested by testers crew - passed review by devs label Oct 12, 2023
@PeterPetrik PeterPetrik requested a review from wonder-sk October 12, 2023 08:03
@PeterPetrik
Copy link
Contributor Author

PeterPetrik commented Oct 12, 2023

@jozef-budac for test, you can create a simple project (or reuse some existing project) and set the simple symbol size to let say 20mm

Screenshot 2023-10-12 at 10 04 12

and then when you load the project on Android and IOS devices the size of symbol should be around this number (let say in range 18-22mm ).

optional bonus points: also have a line feature and measure line width (again in QGIS setting for millimetres)

Would it be possible to add this test to our manual regression testing suite? thanks!

iOS - version 23.10.468711
Android - https://github.com/MerginMaps/input/suites/17148408430/artifacts/979776534

@PeterPetrik PeterPetrik added the bug in not released version Bug in not officially released version, found while testing RC label Oct 12, 2023
@jozef-budac
Copy link

Verified on iOS and test was added: https://app.qase.io/case/INPUT-103

@PeterPetrik PeterPetrik merged commit a5e307c into master Oct 13, 2023
8 checks passed
@PeterPetrik PeterPetrik deleted the ios_sizesymbol branch October 13, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug in not released version Bug in not officially released version, found while testing RC ready-for-testing Ready to be tested by testers crew - passed review by devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple Symbol marker size is half size
3 participants