Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling attempt to upload a project after reaching the project limit #3450

Merged
merged 6 commits into from
May 24, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented May 21, 2024

When attempting to upload a local only project, if the workspace project limit has been reached, the project is now removed from the synchronization pending list and is completely deleted if the project is removed by the user.

PR_3450.mov

Fixes #3403

Copy link

github-actions bot commented May 21, 2024

Pull Request Test Coverage Report for Build 9223917265

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 49 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 60.047%

Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.37%
input/app/synchronizationmanager.cpp 48 60.0%
Totals Coverage Status
Change from base Build 9161804447: 0.06%
Covered Lines: 7674
Relevant Lines: 12780

💛 - Coveralls

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why the project is not valid in the first place? Can you check that please?

@VitorVieiraZ VitorVieiraZ changed the title Handling home projects model when deleting a project after reaching the project limit WIP - Handling attempt to upload a project to server after reaching the project limit May 22, 2024
@VitorVieiraZ VitorVieiraZ changed the title WIP - Handling attempt to upload a project to server after reaching the project limit Handling attempt to upload a project to server after reaching the project limit May 22, 2024
@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera May 22, 2024 20:10
core/merginapi.cpp Show resolved Hide resolved
@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera May 23, 2024 13:38
@VitorVieiraZ VitorVieiraZ changed the title Handling attempt to upload a project to server after reaching the project limit Handling attempt to upload a project after reaching the project limit May 23, 2024
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, otherwise looks good to me!

app/synchronizationmanager.cpp Show resolved Hide resolved
@tomasMizera tomasMizera merged commit f8d7e37 into master May 24, 2024
8 checks passed
@tomasMizera tomasMizera deleted the iss3403 branch May 24, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants