-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling attempt to upload a project after reaching the project limit #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9223917265Details
💛 - Coveralls |
tomasMizera
reviewed
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know why the project is not valid in the first place? Can you check that please?
VitorVieiraZ
changed the title
Handling home projects model when deleting a project after reaching the project limit
WIP - Handling attempt to upload a project to server after reaching the project limit
May 22, 2024
VitorVieiraZ
changed the title
WIP - Handling attempt to upload a project to server after reaching the project limit
Handling attempt to upload a project to server after reaching the project limit
May 22, 2024
tomasMizera
requested changes
May 23, 2024
VitorVieiraZ
changed the title
Handling attempt to upload a project to server after reaching the project limit
Handling attempt to upload a project after reaching the project limit
May 23, 2024
tomasMizera
reviewed
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment, otherwise looks good to me!
tomasMizera
reviewed
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to upload a local only project, if the workspace project limit has been reached, the project is now removed from the synchronization pending list and is completely deleted if the project is removed by the user.
PR_3450.mov
Fixes #3403