Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing override of relations editor bug #3455

Merged
merged 3 commits into from
May 24, 2024
Merged

Fixing override of relations editor bug #3455

merged 3 commits into from
May 24, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented May 23, 2024 •
edited
Loading

Fixing check for whether FormItem::name has nogallery flag in the form's label name in Relation Editor widget type.

Fixes #3452

@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9223769254

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 59.898%
Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.37%
Totals Coverage Status
Change from base Build 9209557888: -0.008%
Covered Lines: 7661
Relevant Lines: 12790
💛 - Coveralls

@VitorVieiraZ VitorVieiraZ changed the title WIP - Fixing override of relations editor bug Fixing override of relations editor bug May 24, 2024
tomasMizera
tomasMizera requested changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small comments, otherwise it looks alright!

app/inpututils.cpp Outdated Show resolved Hide resolved
app/inpututils.cpp Outdated Show resolved Hide resolved
@tomasMizera
Copy link
Collaborator

As regards to the fix itself, I tested it and it looks all good :)
image

tomasMizera
tomasMizera approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adjusting the code! :)

@tomasMizera tomasMizera merged commit 22d1cf7 into master May 24, 2024
9 checks passed
@tomasMizera tomasMizera deleted the overrideRelationsEditorFix branch May 24, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasMizera tomasMizera tomasMizera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override of relations editor does not work
3 participants
@VitorVieiraZ @tomasMizera @inputapp-bot