Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ANR when opening project with searchbar focus #3462

Merged
merged 1 commit into from
May 28, 2024

Conversation

tomasMizera
Copy link
Collaborator

Weird bug here.. When we were trying to set visible property of the entire project controller (MMProjectController.qml) to false while searchBar had focus, the app would freeze (ANR). I spent a few hours debugging and have not found anything interesting. I believe this is coming from Qt (most likely https://bugreports.qt.io/browse/QTBUG-123876) as it started to appear in Qt 6.6.0 and even more in 6.6.3.
Ideally, the best fix would be to have the MMProjectController instantiated dynamically when needed and not play around with the visible property. However, that would be a massive change for now.

Resolves #3027

Thanks @raherin for all the details in the bug report, they helped a lot! Can you please try this build and see if it fixes the issue also for your phone?

@tomasMizera
Copy link
Collaborator Author

tomasMizera commented May 24, 2024

@raherin you will find the build here https://github.com/MerginMaps/mobile/actions/runs/9223933873?pr=3462 (once the build finishes)

Copy link

Pull Request Test Coverage Report for Build 9223933876

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 59.922%

Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
Totals Coverage Status
Change from base Build 9209557888: 0.02%
Covered Lines: 7664
Relevant Lines: 12790

💛 - Coveralls

@tomasMizera tomasMizera added the test-success Label to use for PR testing label May 27, 2024
@tomasMizera
Copy link
Collaborator Author

tomasMizera commented May 27, 2024

Confirmed by @raherin

@tomasMizera tomasMizera merged commit c567e61 into master May 28, 2024
12 checks passed
@tomasMizera tomasMizera deleted the fix-project-opening-anr branch May 28, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-success Label to use for PR testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloading and then opening projects causes app to freeze
4 participants