Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable predictive text on Android #3464

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

tomasMizera
Copy link
Collaborator

@tomasMizera tomasMizera commented May 27, 2024

It seems to be working fine for me now with Qt 6.6.3 without any special hacks we had before. I tested Samsung and Google keyboards and they are working just fine with any type of editors in the form.

Note: to disable predictive text on Android, one needs to either set QT_ANDROID_ENABLE_WORKAROUND_TO_DISABLE_PREDICTIVE_TEXT env variable (this then applies to all inputs) or set Qt.ImhNoPredictiveText | Qt.ImhSensitiveData as inputMethodHints (this then applies only to that one input). See https://bugreports.qt.io/browse/QTBUG-86982?focusedId=706751&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-706751 for more info

Resolves #3434

If the tests are ok, we can close #1768, #2471, #2475 and #2568

@tomasMizera tomasMizera changed the title Enable predictive text on Android WIP: Enable predictive text on Android May 27, 2024
Copy link

github-actions bot commented May 27, 2024

Pull Request Test Coverage Report for Build 9253659175

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 74 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.05%) to 59.928%

Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 3 78.58%
input/core/merginuserinfo.cpp 3 73.76%
input/app/main.cpp 67 32.75%
Totals Coverage Status
Change from base Build 9251419383: -0.05%
Covered Lines: 7669
Relevant Lines: 12797

💛 - Coveralls

@tomasMizera tomasMizera changed the title WIP: Enable predictive text on Android Enable predictive text on Android May 27, 2024
@tomasMizera tomasMizera added the ready-for-testing Ready to be tested by testers crew - passed review by devs label May 27, 2024
@tomasMizera
Copy link
Collaborator Author

Hi @jozef-budac, can I ask you to test this one? We need to check entering of text/numbers in the forms and other inputs. We enabled the prediction texts and want to see if everything works fine.

Android build: https://github.com/MerginMaps/mobile/actions/runs/9253659183?pr=3464

Copy link
Contributor

@VitorVieiraZ VitorVieiraZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine on my LG Android 10 and Samsung Android 14 devices.

@tomasMizera tomasMizera merged commit 6f2e6a7 into master May 28, 2024
6 of 12 checks passed
@tomasMizera tomasMizera deleted the enable-predictive-text branch May 28, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing Ready to be tested by testers crew - passed review by devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable text predictions on Android Decimal on Samsung phone
4 participants