Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generic error message in login screen #3467

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

tomasMizera
Copy link
Collaborator

Changed the generic error message, it is visible if the server is unavailable or the app does not have an internet connection. Previously the text did not mention the possibility of no internet connection.

@tomasMizera tomasMizera requested a review from VitorVieiraZ May 27, 2024 12:41
Copy link

Pull Request Test Coverage Report for Build 9254868188

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 59.936%

Files with Coverage Reduction New Missed Lines %
input/core/merginapi.cpp 3 78.58%
input/core/merginuserinfo.cpp 3 73.76%
Totals Coverage Status
Change from base Build 9251419383: -0.04%
Covered Lines: 7670
Relevant Lines: 12797

💛 - Coveralls

@tomasMizera tomasMizera merged commit 1ea0050 into master May 28, 2024
12 checks passed
@tomasMizera tomasMizera deleted the update-error-msg branch May 28, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants