Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for multiple lines in map tip for images #3485

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Support for multiple lines in map tip for images #3485

merged 5 commits into from
Jun 14, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented May 31, 2024 •
edited
Loading

AttributePreviewController::mapTipImage() now supports multiline text with expressions.
E.g.:

# image
file:///[%@project_folder%]/mapTip/[%
CASE WHEN "Checkbox" THEN
	'bear.png'
ELSE
	'beaver.png'
END
%]

In app:

Fixes #1106

@tomasMizera tomasMizera added the FROZEN 🥶 do not merge before upcoming release label Jun 3, 2024
tomasMizera
tomasMizera reviewed Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an autotest for this scenario

@tomasMizera tomasMizera removed the FROZEN 🥶 do not merge before upcoming release label Jun 4, 2024
@VitorVieiraZ VitorVieiraZ changed the title WIP - Support for multiple lines in map tip for images Support for multiple lines in map tip for images Jun 5, 2024
@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera June 5, 2024 17:05
tomasMizera
tomasMizera requested changes Jun 10, 2024
View reviewed changes
app/test/testattributepreviewcontroller.cpp Outdated Show resolved Hide resolved
app/test/testattributepreviewcontroller.cpp Outdated Show resolved Hide resolved
@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera June 10, 2024 14:41
@tomasMizera
Copy link
Collaborator

Irrelevant iOS CI failure

tomasMizera
tomasMizera approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, let's wait if MacOS CI passes

@tomasMizera tomasMizera merged commit 1159b7c into master Jun 14, 2024
8 of 9 checks passed
@tomasMizera tomasMizera deleted the fix/mapTipImage branch June 14, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasMizera tomasMizera tomasMizera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map tip for images cannot span multiple lines
3 participants
@VitorVieiraZ @tomasMizera @inputapp-bot