Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling accidental double-taps on buttons with MMSingleClickMouseArea #3532

Merged
merged 12 commits into from
Jul 19, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Jul 9, 2024

New component MMSingleClickMouseArea for single-click detection. It temporarily disables further clicks using a Timer to prevent multiple triggers shortly after the first click.

Fixes #3012

Copy link

github-actions bot commented Jul 9, 2024

Pull Request Test Coverage Report for Build 9991957790

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 59.994%

Totals Coverage Status
Change from base Build 9940182064: 0.008%
Covered Lines: 7696
Relevant Lines: 12828

💛 - Coveralls

@VitorVieiraZ VitorVieiraZ changed the title WIP - Handling accidental double-taps on buttons with MMSingleClickMouseArea Handling accidental double-taps on buttons with MMSingleClickMouseArea Jul 10, 2024
@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera July 10, 2024 14:41
@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera July 12, 2024 16:00
@VitorVieiraZ VitorVieiraZ force-pushed the fix/doubleClickRelationsForm branch from b8fce5a to cb42a0d Compare July 15, 2024 12:14
@VitorVieiraZ VitorVieiraZ force-pushed the master branch 2 times, most recently from e9ea4f5 to 8004949 Compare July 15, 2024 13:19
@VitorVieiraZ VitorVieiraZ force-pushed the fix/doubleClickRelationsForm branch from cb42a0d to f8f603b Compare July 15, 2024 13:21
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good now, thanks! I found one more place that would benefit from this new component. Can we please add it when opening child feature in relation form editors? It is again in both relation form editors when calling openLinkedFeature signal.

@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera July 16, 2024 13:19
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last remaining place and I think we are good to go :)

app/qml/form/editors/MMFormGalleryEditor.qml Outdated Show resolved Hide resolved
@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera July 18, 2024 14:32
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the updates!

@tomasMizera tomasMizera merged commit 619d682 into master Jul 19, 2024
12 checks passed
@tomasMizera tomasMizera deleted the fix/doubleClickRelationsForm branch July 19, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accidental double-taps on buttons in relation or image widgets
3 participants