Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not able to close drawer using system back button #3556

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

ValentinBuira
Copy link
Contributor

This PR try to fix an error where in some case you couldn't close a drawer using the system back button

This happened because the control focus was not transferred correctly

This bug was found during release testing and relate to #3525

@tomasMizera tomasMizera linked an issue Aug 5, 2024 that may be closed by this pull request
@ValentinBuira
Copy link
Contributor Author

I also fixed the same issue for MMFormPage

I have been pondering and in the end I moved the handling event to the root of MMFormPage, and I removed this part of the code which as no used anymore AFAIK:

-    onVisibleChanged: function( visible ) {
-      if ( visible )
-        backHandler.forceActiveFocus()
-    }

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, let's see what testing brings

@tomasMizera tomasMizera merged commit b1f9b2a into master Aug 6, 2024
12 checks passed
@tomasMizera tomasMizera deleted the fix-drawer-focus branch August 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsaved changes dialog not displayed when using back button
3 participants