Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting MMProjectLoadingPage text to respect safe area #3564

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Adjusting MMProjectLoadingPage text to respect safe area #3564

merged 2 commits into from
Aug 26, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Aug 9, 2024 •
edited
Loading

Before:

After

Landscape Portrait

@VitorVieiraZ VitorVieiraZ added bug android 🤖 Relates to Android app version labels Aug 9, 2024
@VitorVieiraZ VitorVieiraZ added this to the 2024.4.0 milestone Aug 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Pull Request Test Coverage Report for Build 10326883109

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 60.194%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 3 73.76%
input/app/projectsmodel.cpp 6 69.17%
Totals Coverage Status
Change from base Build 10315351843: 0.0%
Covered Lines: 7753
Relevant Lines: 12880
💛 - Coveralls

tomasMizera
tomasMizera approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we would want to use MMPage instead, but this works too 👌🏻

@tomasMizera tomasMizera merged commit 25b7a91 into master Aug 26, 2024
11 of 12 checks passed
@tomasMizera tomasMizera deleted the fix/openProjectSplashScreenSafeArea branch August 26, 2024 12:13
@alexd0793 alexd0793 added the test-success Label to use for PR testing label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasMizera tomasMizera tomasMizera approved these changes

Assignees
No one assigned
Labels
android 🤖 Relates to Android app version bug test-success Label to use for PR testing
Projects
None yet
Milestone
2024.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@VitorVieiraZ @tomasMizera @alexd0793