Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize feature model sorting #3638

Merged
merged 4 commits into from
Oct 9, 2024
Merged

optimize feature model sorting #3638

merged 4 commits into from
Oct 9, 2024

Conversation

uclaros
Copy link
Contributor

@uclaros uclaros commented Oct 4, 2024

fix #3637

Copy link

github-actions bot commented Oct 4, 2024

Pull Request Test Coverage Report for Build 11243801874

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 164 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.2%) to 60.149%

Files with Coverage Reduction New Missed Lines %
input/app/featuresmodel.h 1 0.0%
input/app/attributes/attributecontroller.cpp 1 77.23%
input/app/notificationmodel.cpp 3 49.44%
input/core/merginuserauth.cpp 9 75.95%
input/core/merginapi.cpp 13 78.95%
input/app/valuerelationfeaturesmodel.cpp 20 75.0%
input/app/featuresmodel.cpp 32 68.98%
input/app/main.cpp 85 32.75%
Totals Coverage Status
Change from base Build 11166700037: -0.2%
Covered Lines: 7728
Relevant Lines: 12848

💛 - Coveralls

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on the call, marking it here for reference

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed

  • add flag to not follow attribute table sorting
  • see if we can get info if QGIS will order features or a data provider itself

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now, thanks! We will start testing

@tomasMizera tomasMizera merged commit d830c0e into master Oct 9, 2024
12 checks passed
@tomasMizera tomasMizera deleted the tune-sorting branch October 9, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App lags or freezes when viewing layers with many features in Layer view since update to 2024.4.0
3 participants