Add tests to verify that rebase is working correctly #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when rebase is successful - when rebase fails because local gpkg got schema changed - when rebase fails because remote gpkg got schema changed The tests are parametrized to check also the case when there is a pending sqlite connection to gpkg (e.g. layer open in QGIS), to make sure things work correctly in that case too (no sync failures / data corruption or loss).
Now we make a temporary copy of the geopackage if we upload its full content instead of just a diff, to make sure that we do not miss any data (checkpoint may fail if there's a pending reader/writer).
This is because currently pygeodiff bundles its own sqlite3 library different from python's sqlite3 library, and that's causing clashes.
|
All seems good. |
This was referenced Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tests:
The tests are parametrized to check also the case when there is a pending
sqlite connection to gpkg (e.g. layer open in QGIS), to make sure things work
correctly in that case too (no sync failures / data corruption or loss).
Ensures that #96 and MerginMaps/qgis-plugin#246 are fixed now (thanks to fix for #30)