Skip to content

Conversation

@JanCaha
Copy link
Contributor

@JanCaha JanCaha commented Aug 6, 2025

First download project of project should utilize system temp directory instead of .mergin to avoid issues with other sync tools.

Fixes also part of pull that was not yet handled correctly.

Fixes #183

This fixes download part of #183 and complements work in #253

@coveralls
Copy link

coveralls commented Aug 7, 2025

Pull Request Test Coverage Report for Build 17380267703

Details

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 80.423%

Files with Coverage Reduction New Missed Lines %
mergin/client_pull.py 1 84.19%
Totals Coverage Status
Change from base Build 16775335899: -0.02%
Covered Lines: 3500
Relevant Lines: 4352

💛 - Coveralls

@JanCaha JanCaha requested a review from MarcelGeo August 7, 2025 12:26
@MarcelGeo
Copy link
Contributor

@RastoHu

Best way to test this will be to copy existing project to directory which is syncing with One Drive.

  • make some changesin qgis to geopackages in different folder -> sync
  • pull changes in plugin to your OneDrive synced directory
  • you will not see any errors by download / pull of projects.

@MarcelGeo MarcelGeo requested a review from wonder-sk September 1, 2025 08:45
@JanCaha
Copy link
Contributor Author

JanCaha commented Sep 1, 2025

Everything should be fixed here.

@MarcelGeo MarcelGeo requested a review from wonder-sk September 1, 2025 15:15
@JanCaha JanCaha changed the title Download project temp dir Download and pull project to temp dir Sep 2, 2025
Copy link
Contributor

@wonder-sk wonder-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the temporary directory naming more consistent? It is tmp_dir or temp_dir or temp_directory - let's pick just one 🙂
(I think Marcel would prefer tmp_dir so that we don't get new conflicts in his "push v2" branch)

JanCaha and others added 2 commits September 2, 2025 13:14
@MarcelGeo MarcelGeo requested a review from wonder-sk September 2, 2025 11:39
@MarcelGeo
Copy link
Contributor

Will bemerged after testing by @RastoHu will be done.

@RastoHu
Copy link

RastoHu commented Sep 8, 2025

@JanCaha @MarcelGeo
On which version (build) of the plugin should I test it?

@JanCaha
Copy link
Contributor Author

JanCaha commented Sep 8, 2025

Should not really matter. This background stuff for plugin so it should work with any version

Copy link
Contributor

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed.

@MarcelGeo MarcelGeo merged commit 33aa6cf into master Sep 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Temporary files during download/pull should go to temp directory

6 participants