-
Couldn't load subscription status.
- Fork 9
Download and pull project to temp dir #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 17380267703Details
💛 - Coveralls |
|
Best way to test this will be to copy existing project to directory which is syncing with One Drive.
|
Co-authored-by: Martin Dobias <[email protected]>
|
Everything should be fixed here. |
…ad-project-temp-dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make the temporary directory naming more consistent? It is tmp_dir or temp_dir or temp_directory - let's pick just one 🙂
(I think Marcel would prefer tmp_dir so that we don't get new conflicts in his "push v2" branch)
Co-authored-by: Martin Dobias <[email protected]>
|
Will bemerged after testing by @RastoHu will be done. |
|
@JanCaha @MarcelGeo |
|
Should not really matter. This background stuff for plugin so it should work with any version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passed.
First download project of project should utilize system temp directory instead of .mergin to avoid issues with other sync tools.
Fixes also part of pull that was not yet handled correctly.
Fixes #183
This fixes download part of #183 and complements work in #253