Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more validation checks #353

Merged
merged 7 commits into from
Mar 28, 2022
Merged

Add more validation checks #353

merged 7 commits into from
Mar 28, 2022

Conversation

alexbruy
Copy link
Contributor

@alexbruy alexbruy commented Mar 16, 2022

Add more validation checks:

  • using relative path in the Attachment widget
  • Attachment widget does not use local path, e.g. /home/user/some/path
  • expression-based path should not be set as a default path (to work correctly it should be set as data-defined)
  • database structure was changed. For now only simple check that there are no new/removed/renamed fields

Fixes #254 and #289.

ref CU-27pvwte

@ghost
Copy link

ghost commented Mar 18, 2022

Task linked: CU-27pvwte Plugin Validations

@alexbruy alexbruy force-pushed the validation-checks branch from 450609f to df96667 Compare March 24, 2022 15:53
@alexbruy alexbruy requested a review from wonder-sk March 24, 2022 15:56
Copy link
Contributor

@PeterPetrik PeterPetrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes! can you please add automatic tests?

@alexbruy
Copy link
Contributor Author

Tests added and I tried to add them to the workflow, but I have never worked with GitHub actions before. Seems I'm doing something wrong when mounting volume to docker image and as a result test runner can't find tests.

Copy link
Contributor

@PeterPetrik PeterPetrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@PeterPetrik PeterPetrik merged commit 1d580ac into master Mar 28, 2022
@PeterPetrik PeterPetrik deleted the validation-checks branch March 28, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if the Attachment widget is using the correct settings
3 participants