Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roles refactoring: Add new project_member table, update getter/setter… #319

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Roles refactoring: Add new project_member table, update getter/setter… #319

merged 5 commits into from
Nov 18, 2024

Conversation

MarcelGeo
Copy link
Contributor

@MarcelGeo MarcelGeo commented Nov 5, 2024 •
edited
Loading

@MarcelGeo MarcelGeo requested a review from harminius November 5, 2024 07:55
MarcelGeo

This comment was marked as resolved.

Sign in to view

mostlyAtNight
mostlyAtNight reviewed Nov 12, 2024
View reviewed changes
Copy link

@mostlyAtNight mostlyAtNight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi guys, I've reviewed the migration script thoroughly but have not looked at any other part of the MR.

Some other thoughts:

  • we should ensure an upgrade/downgrade cycle results in exactly the same states for the tables affected
  • do we need to grant any permissions on new tables, or these will be taken care of automaticlaly with default schema permissions?

server/migrations/community/d02961c7416c_add_project_member_table.py Show resolved Hide resolved
server/migrations/community/d02961c7416c_add_project_member_table.py Outdated Show resolved Hide resolved
server/migrations/community/d02961c7416c_add_project_member_table.py Show resolved Hide resolved
server/migrations/community/d02961c7416c_add_project_member_table.py Outdated Show resolved Hide resolved
server/migrations/community/d02961c7416c_add_project_member_table.py Outdated Show resolved Hide resolved
server/migrations/community/d02961c7416c_add_project_member_table.py Show resolved Hide resolved
server/migrations/community/d02961c7416c_add_project_member_table.py Outdated Show resolved Hide resolved
MarcelGeo
MarcelGeo commented Nov 13, 2024
View reviewed changes
Copy link
Contributor Author

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downgrade, upgrade working for my local data. I also checked if everything is ok with data.

server/mergin/auth/schemas.py Show resolved Hide resolved
server/mergin/sync/models.py Show resolved Hide resolved
@MarcelGeo MarcelGeo removed the request for review from harminius November 13, 2024 12:42
mostlyAtNight
mostlyAtNight approved these changes Nov 14, 2024
View reviewed changes
Copy link

@mostlyAtNight mostlyAtNight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good from my side

@MarcelGeo MarcelGeo merged commit e09239e into develop-roles-refactor Nov 18, 2024
3 of 4 checks passed
@MarcelGeo MarcelGeo deleted the roles-refactor-db-migration branch November 18, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varmar05 varmar05 varmar05 left review comments

@mostlyAtNight mostlyAtNight mostlyAtNight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcelGeo @mostlyAtNight @varmar05