Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop roles refactor #341

Merged
merged 22 commits into from
Dec 11, 2024
Merged

Develop roles refactor #341

merged 22 commits into from
Dec 11, 2024

Conversation

MarcelGeo
Copy link
Contributor

No description provided.

varmar05 and others added 21 commits October 31, 2024 15:51
@varmar05
Roles refactoring: Add new project_member table, update getter/setter…
b89a313 
… for project role
@MarcelGeo
Merge remote-tracking branch 'origin/develop-roles-refactor' into rol…
3bdd3dd 
…es-refactor-db-migration
@varmar05
Fix migration script to work with all deployments
5bdeef7
@varmar05
Fix migration script
8277055
@varmar05
Fix downgrade in migration script
d7d7640
@varmar05
Roles refactor: Fix API responses with new internal db models
3e4ab10
@MarcelGeo
Merge pull request #319 from MerginMaps/roles-refactor-db-migration
e09239e 
Roles refactoring: Add new project_member table, update getter/setter…
@varmar05
Roles refactor: Fix depracated update project access endpoint
106da88
@varmar05
Merge branch 'develop' into develop-roles-refactor
3c8595b
@varmar05
Merge branch 'develop-roles-refactor' into fix_current_access_api
fc8e11d
@varmar05
Address comments
75deca7
@varmar05
More fixes for project access rework
dcc7b86
@varmar05
Rewrite pagination query to use subquery instead of join
0b00f89
@MarcelGeo
Merge pull request #332 from MerginMaps/fix_current_access_api
ead9554 
Fix current access api
@varmar05
Roles refactor: New public API with reworked project roles
4d34f5d
@harminius
Create project fix
1b66b14
@harminius
Be safe to have mandatory public attribute
4578903
@harminius
Add test for public argument
be604ea
@varmar05
Address review comments
56cd008
@varmar05
Rename functions to match API naming
dfa0d46
@MarcelGeo
Merge pull request #337 from MerginMaps/new_members_api
1fbdb12 
Roles refactor: New public API with reworked project roles
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12273460272

Details

  • 407 of 415 (98.07%) changed or added relevant lines in 22 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.09%) to 93.481%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server/mergin/sync/public_api_v2_controller.py 54 56 96.43%
server/mergin/sync/interfaces.py 17 20 85.0%
server/mergin/sync/models.py 63 66 95.45%
Files with Coverage Reduction New Missed Lines %
server/mergin/sync/models.py 1 98.2%
server/mergin/sync/schemas.py 1 93.16%
Totals Coverage Status
Change from base Build 12250588230: 0.09%
Covered Lines: 6582
Relevant Lines: 7041
💛 - Coveralls

@MarcelGeo MarcelGeo merged commit c28dc1d into develop Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harminius harminius harminius approved these changes

@varmar05 varmar05 Awaiting requested review from varmar05

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarcelGeo @coveralls @harminius @varmar05