Use regular install for CI tests #463
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jfrost-mo
force-pushed
the
356_test_normal_install
branch
from
a21e12f
to
49101b2
Compare
|
Probably the thing to do is to ditch the end-to-end CI tests, just keeping the --help one for validating that the This will probably involve marking the |
jfrost-mo
commented
Jul 18, 2024
| @@ -37,7 +37,7 @@ jobs: | |||
| run: | | |||
| # Install package and run pytest. | |||
| echo '::group::Installing local package' | |||
| python3 -m pip install -e . | |||
| python3 -m pip install . | |||
There was a problem hiding this comment.
This causes the test coverage to drop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI tests are now installed with a regular pip install, rather than being installed editabally. This ensures they are more realistic.