Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Switch to data time cycling to support multiple models and multiple case studies or trials #765

Open
wants to merge 90 commits into
base: main
Choose a base branch
from

Commits on Sep 16, 2024

  1. Add multiple models to rose edit configuration

    Also gone through and removed some unneeded things, added titles, etc.
    
    Still need to go through the diagnostics.
    
    Split diagnostics into sections, add input variable table
    
    Also link in more models, so 10 are now supported.
    
    Improvements to rose edit metadata
    
    Fix a bunch of validation issues
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    35b9dd1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c987f80 View commit details
    Browse the repository at this point in the history
  3. Change how data is fetched to work on data time

    Also now use subclasses for getting individual files from the various
    data sources.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    302b1f8 View commit details
    Browse the repository at this point in the history
  4. Modify data fetching in workflow to fetch per model

    Grab rose template variables directly, rather than via jinja context
    
    Add workflow exported functions to __all__
    
    Add licence header to jinja_utils
    
    Require success for processing tasks in workflow
    
    Housekeep only on success, but finish workflow regardless
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d8f3042 View commit details
    Browse the repository at this point in the history
  5. Change recipe format to just use steps, and update infra for running …

    …them
    
    I've updated one recipe for now, but they will all have to be converted.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2816af6 View commit details
    Browse the repository at this point in the history
  6. Add cycling for trials

    The final cycle point task are skipped if doing a continuous trial
    without a defined end date.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7ec7031 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    18f8ae5 View commit details
    Browse the repository at this point in the history
  8. Remove unneeded recipes

    They have all been replaced my the more generic version that work for
    both the UM and LFRic.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c0827cf View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e3ad967 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f3f89a4 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2fe51c8 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4ec94c3 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    baa5400 View commit details
    Browse the repository at this point in the history
  14. Differentiate output directories for different case dates

    Use cycle point for deterministic resolving.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c656815 View commit details
    Browse the repository at this point in the history
  15. Remove duplicated include file

    It was also invalid due to referencing non-existent variables.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    37e0b35 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    8ae9b99 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    7b764f9 View commit details
    Browse the repository at this point in the history
  18. Convert more recipes

    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a87ed7e View commit details
    Browse the repository at this point in the history
  19. Split rose metadata into multiple files

    Also rearrange pressure level metadata.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    39b9816 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    d216635 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    3855fd7 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    9f7ad76 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    928390c View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    adea843 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    6f440c3 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    1e4c235 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    1cc5866 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    cc7d393 View commit details
    Browse the repository at this point in the history
  29. Convert transect recipe

    Q-Q plot recipe is partially converted, pending Issue #808.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4d46c7d View commit details
    Browse the repository at this point in the history
  30. Fix CLI tests

    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6e16af2 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    41443f0 View commit details
    Browse the repository at this point in the history
  32. Fix run_cset_recipe tests

    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    553ab60 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    3ec2c85 View commit details
    Browse the repository at this point in the history
  34. Add some more tests

    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    840ec57 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    d7c997b View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    1948f05 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    1c2328e View commit details
    Browse the repository at this point in the history
  38. Add fetch_data tests

    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    76ba149 View commit details
    Browse the repository at this point in the history
  39. Reference UTC timezone as datetime.timezone.utc

    The datetime.UTC alias was only added in python 3.11.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f56e8d5 View commit details
    Browse the repository at this point in the history
  40. Add workaround for old python not supporting ISO 8601 datetimes

    This should be removed when we drop python 3.10 support.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e8d8117 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    4ed6841 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    9900aa1 View commit details
    Browse the repository at this point in the history
  43. Fix typo in rose metadata

    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1915b61 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    d1f8302 View commit details
    Browse the repository at this point in the history
  45. Finish website on compute platform

    Now it touches the data to generate the index, it probably shouldn't be
    run on the cylc scheduler.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    68bdfd9 View commit details
    Browse the repository at this point in the history
  46. Remove outdated comment

    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6790771 View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    eb36acc View commit details
    Browse the repository at this point in the history
  48. Remove parallel and collate steps

    We've now gone back to just steps.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3063f32 View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    34a1069 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    7e75674 View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    40e54ef View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    1f3a941 View commit details
    Browse the repository at this point in the history
  53. Update rose-meta.conf

    Sylviabohnenstengel authored and jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    322066b View commit details
    Browse the repository at this point in the history
  54. Update documentation.rst

    Sylviabohnenstengel authored and jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2276c9f View commit details
    Browse the repository at this point in the history
  55. Change datetime examples to use YYYYMMDDThhmmZ format

    It is more familiar to users.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    018126b View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    0279838 View commit details
    Browse the repository at this point in the history
  57. Clarify that CSET_ANALYSIS_OFFSET

    Note that if fixes differences between the initiation time and the first
    validity time.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5442b92 View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    29d5204 View commit details
    Browse the repository at this point in the history
  59. Number models from 0 to allow directly using as index

    This removes the -1 from all usage in include files.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    026baa3 View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    30f83a0 View commit details
    Browse the repository at this point in the history
  61. Configuration menu
    Copy the full SHA
    e72e40f View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    cade4fc View commit details
    Browse the repository at this point in the history
  63. Clarify STASH code format

    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c24ecc6 View commit details
    Browse the repository at this point in the history
  64. Remove useless help text

    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    330eb59 View commit details
    Browse the repository at this point in the history
  65. Configuration menu
    Copy the full SHA
    5c68f5e View commit details
    Browse the repository at this point in the history
  66. Configuration menu
    Copy the full SHA
    7a715d6 View commit details
    Browse the repository at this point in the history
  67. Do full range of models

    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    48ba325 View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    c30c3cc View commit details
    Browse the repository at this point in the history
  69. Configuration menu
    Copy the full SHA
    39c9650 View commit details
    Browse the repository at this point in the history
  70. Default to False when setting doesn't exist

    This is useful if the setting is not in the rose-suite.conf
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7669e5e View commit details
    Browse the repository at this point in the history
  71. Configuration menu
    Copy the full SHA
    ab490eb View commit details
    Browse the repository at this point in the history
  72. Configuration menu
    Copy the full SHA
    d51a952 View commit details
    Browse the repository at this point in the history
  73. Configuration menu
    Copy the full SHA
    8404892 View commit details
    Browse the repository at this point in the history
  74. Configuration menu
    Copy the full SHA
    c1be5f4 View commit details
    Browse the repository at this point in the history
  75. Configuration menu
    Copy the full SHA
    f101c97 View commit details
    Browse the repository at this point in the history
  76. Move HTTPFileRetriever into fetch_data module

    Also add a test.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1ce5f15 View commit details
    Browse the repository at this point in the history
  77. Fix HTTPFileRetriever

    The output_dir was in the wrong place, so it was making a POST request.
    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    acc401c View commit details
    Browse the repository at this point in the history
  78. Simplify type signature

    jfrost-mo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a0aff82 View commit details
    Browse the repository at this point in the history
  79. Configuration menu
    Copy the full SHA
    e77ab07 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    671d58f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    725e388 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    32b0952 View commit details
    Browse the repository at this point in the history
  4. Remove extraneous )

    jfrost-mo committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    86a7406 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b565a04 View commit details
    Browse the repository at this point in the history
  6. Bundle recipes and example data into documentation

    This prevents needing to rely on external hosts for these. I did need to drop
    the example commands to fetch the resources via curl, but they were probably
    confusing anyway.
    jfrost-mo committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f50ddfe View commit details
    Browse the repository at this point in the history
  7. Remove preprocessing settings

    They are not implemented yet, and can be re-added when they are.
    jfrost-mo committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d2d305b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7d94c59 View commit details
    Browse the repository at this point in the history
  9. Make area constraint much stricter, and handle date line

    The operator now requires all arguments to either be numbers, or all be None
    if you don't want to constrain the area.
    
    The test has been mildly improved, so at least it checks for both of the
    named functions on the coordinates, though it still doesn't test that they
    do anything.
    jfrost-mo committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a1bc3ce View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    638f018 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Configuration menu
    Copy the full SHA
    f18255b View commit details
    Browse the repository at this point in the history