Merge install_local_cset into build_conda so environment is setup in a single cylc task #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jfrost-mo
force-pushed
the
merge_install_local_cset_build_conda
branch
from
54ffa52
to
42d1a84
Compare
The install_local_cset script was converted to bash as part of this. This means we only have a single job for environment setup, and test that the environment actually works as part of that. We also skip copying non-git hidden files when installing local CSET, as they can often include large things like conda environments that slow the script significantly.
jfrost-mo
force-pushed
the
merge_install_local_cset_build_conda
branch
from
42d1a84
to
87dab11
Compare
jfrost-mo
changed the title
dasha-shchep
approved these changes
Aug 15, 2024
|
Thanks. Missed that when I pulled this out of #765. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install_local_cset script was converted to bash as part of this.
This means we only have a single job for environment setup, and test that the environment actually works as part of that.
We also skip copying non-git hidden files when installing local CSET, as they can often include large things like conda environments that slow the script significantly.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
GitHub Copilot was used in this PR.