-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add date to cset plot menu items #934
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Ah, the tests are failing because the space should only be added if the date is. |
plot_metadata["category"]: { | ||
directory.name: plot_metadata["title"] | ||
+ " " | ||
+ os.getenv("CYLC_TASK_CYCLE_POINT", "") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plot_metadata["category"]: { | |
directory.name: plot_metadata["title"] | |
+ " " | |
+ os.getenv("CYLC_TASK_CYCLE_POINT", "") | |
} | |
plot_metadata["category"]: { | |
directory.name: plot_metadata["title"] | |
+ " " | |
+ os.getenv("CYLC_TASK_CYCLE_POINT", "") | |
}.strip() |
This will strip any trailing spaces. Once the change is made ping it back to me and I'll re-review.
Adding in the date to the CSET plots menu
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.