-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add support/config for InstanceSegmentationMask #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
InstanceSegmentationMask
* chore(main): release apiv2 1.13.0 * chore: Updated [staging,prod] values.yaml image tags to sha-1db3cdf --------- Co-authored-by: czi-github-helper[bot] <95879977+czi-github-helper[bot]@users.noreply.github.com> Co-authored-by: czi-github-helper[bot] <+czi-github-helper[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few markers for potential questions
@@ -93,6 +93,13 @@ annotations: OPTIONAL | |||
delimiter: OPTIONAL, STRING (DEFAULT ',') | |||
parent_filters: see InstanceSegmentation.parent_filters | |||
exclude: SEE InstanceSegmentation.exclude | |||
- InstanceSegmentationMask: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see for the instance seg there is:
- InstanceSegmentation:
file_format: REQUIRED, STRING
# NOTE: glob_string and glob_strings are mutually exclusive, exactly one is REQUIRED
glob_string: OPTIONAL, STRING (REGEX)
glob_strings:
- OPTIONAL, STRING (REGEX)
is_visualization_default: OPTIONAL, BOOLEAN (DEFAULT FALSE)
is_portal_standard: OPTIONAL, BOOLEAN (DEFAULT FALSE)
binning: OPTIONAL, FLOAT (DEFAULT 1) (POSITIVE)
filter_value: OPTIONAL, STRING
order: OPTIONAL, STRING (DEFAULT xyz)
we should check if binning, order, filter_value, is_portal_standard
should be included
schema/core/v1.1.0/metadata.yaml
Outdated
@@ -629,6 +629,13 @@ classes: | |||
description: File and sourcing data for an instance segmentation annotation. Annotation that identifies individual instances of object shapes. | |||
attributes: # no extended attributes | |||
|
|||
AnnotationInstanceSegmentationMaskFile: | |||
is_a: AnnotationOrientedPointFile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More likely AnnotationSourceFile
schema/core/v1.1.0/metadata.yaml
Outdated
aliases: | ||
- InstanceSegmentationMask | ||
description: File and sourcing data for an instance segmentation mask annotation. Annotation that identifies individual instances of object shape masks. | ||
attributes: # no extended attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This we should check, likely possibilities are:
labels
scale_factor
@@ -775,6 +775,13 @@ classes: | |||
description: File and sourcing data for an instance segmentation annotation. Annotation that identifies individual instances of object shapes. | |||
attributes: # no extended attributes | |||
|
|||
AnnotationInstanceSegmentationMaskFile: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we modify both the 1.1.0 version and the 2.0.0 or just the 2.0?
…c) (chanzuckerberg#535) * fix CTF import (maps to tiltseries section index rather than mdoc) * fix tests
…erberg#534) fix dose rate and total flux for ml challenge data.
…rg#494) * SABER annotation deposition. * lint * fix run name retrieval * fix source definition. * fix files names * add keyphoto * Empty commit to trigger workflow.
* minicell config setup. * update dates and fix tilt axis * fix dates * annotations need rescaling * some additional description fixes * fix dose rate * update deposition date to push up in table. * add ctfs * fix CTF import (maps to tiltseries section index rather than mdoc) * fix tests
* chore(main): release apiv2 1.13.1 * chore: Updated [staging,prod] values.yaml image tags to sha-710a5f2 --------- Co-authored-by: czi-github-helper[bot] <95879977+czi-github-helper[bot]@users.noreply.github.com> Co-authored-by: czi-github-helper[bot] <+czi-github-helper[bot]@users.noreply.github.com>
…ackend into feature/CC-429
Relates to
Description