-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Introduce concept of dynamic relationships #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Feature/sckan 427 Dynamic relationships - frontend implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks pretty good, great job to both @Salam-Dalloul and @afonsobspinto.
@afonsobspinto one more comment, triples in combination of name+uri+relationship should be unique, I can see from the code that you can create the same triple per relationship as many times as you want. |
fix: Fix autocomplete select/unselect issue
|
feat: Replaces hardcoded configurations; Updates database constraints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
6ffb1f5
to
dfc6f0e
Compare
dfc6f0e
to
4b582a4
Compare
Closes https://metacell.atlassian.net/browse/SCKAN-426
Add new Relationship (custom property), Triple (options for each custom property), ConnectivityStatementTriple (option selected for a relationship in a connectivity statement); + migrations
Updates admin page to allow Relationship and Triple creations (+ also a simple inline for the ConnectivityStatementTriple)
Adds new ConnectivityStatementTriple viewset to support the webapp needs (see https://metacell.atlassian.net/browse/SCKAN-426?focusedCommentId=20071 thread for details)
Adds inject_dynamic_relationship_schema function to inject the created relationships into the json schema endpoint.
Updates export to add a new row for each statement_triples that exists in the connectivity statement to be exported
(example https://docs.google.com/spreadsheets/d/1s9mynK-XYHZAjWu95_bO9gFTI1hctylDHoK4BOqSbHo/edit?usp=sharing)
Misc: