Skip to content

feat: Introduce concept of dynamic relationships #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Jun 23, 2025
Merged

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented Jun 4, 2025

Closes https://metacell.atlassian.net/browse/SCKAN-426

Misc:

  • Reposition CSRF_TRUSTED_ORIGINS so they are not overwritten by cloudharness django settings
  • Make frontend proxy redirect to 127.0.0.1 opposed to localhost
  • Add port-forward.sh ch's utility for the unlikely need of wanting to run connected to a remote cluster

@afonsobspinto afonsobspinto marked this pull request as ready for review June 4, 2025 17:13
@afonsobspinto afonsobspinto requested a review from ddelpiano June 4, 2025 17:13
Copy link
Member

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks pretty good, great job to both @Salam-Dalloul and @afonsobspinto.

@Salam-Dalloul Salam-Dalloul requested a review from ddelpiano June 13, 2025 15:40
@ddelpiano
Copy link
Member

ddelpiano commented Jun 13, 2025

@afonsobspinto one more comment, triples in combination of name+uri+relationship should be unique, I can see from the code that you can create the same triple per relationship as many times as you want.

@afonsobspinto
Copy link
Member Author

@afonsobspinto one more comment, triples in combination of name+uri+relationship should be unique, I can see from the code that you can create the same triple per relationship as many times as you want.

#483

ddelpiano
ddelpiano previously approved these changes Jun 17, 2025
Copy link
Member

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@afonsobspinto afonsobspinto force-pushed the feature/SCKAN-426 branch 2 times, most recently from 6ffb1f5 to dfc6f0e Compare June 17, 2025 15:19
@ddelpiano ddelpiano merged commit a052c52 into develop Jun 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants