add query to the wiki url to hide the header #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wiki issue #355 - this improves display of the wiki when it is embedded in MetaOS.
alalonde
reviewed
Oct 5, 2022
Any links that currently link out to the wiki will work as normal but yes, there's a couple that should be updated - 2 in the megamenu for a start. I'll update them. |
luxumbra
force-pushed
the
feat/wiki-355-hide-wiki-header
branch
from
922e05a to
e97c0b0
Compare
|
@alalonde i have updated the 3 other wiki references in the megamenu but i think other links to the wiki that are present throughout only link out to the wiki and don't iframe the wiki in MetaOS. Would be nice if we didn't have to link out and could keep all wiki links iframed but that is a bigger job that we could maybe tackle after v1.0? |
|
Successfully undeployed the Preview of this Pull Request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What features/fixes does this PR include?
adds a query to the url for the wiki so it hides and applies some specific styles to the wiki header when it is embedded in metaOS.
We've also removed the old wiki homepage and added a 301 redirect in Vercel to handle the removal of
/docs/from wiki URLs.Please provide the GitHub issue number
Wiki issue 355
Requires MetaFam/metagame-wiki#356 to be merged first.
Follow up Improvement Ideas
Implementation
Describe technical (nontrivial / non-obvious) parts of your code
Side effects
Assets
[Include screenshots/videos if it makes reviewing easier.]