Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* SIP-29: Snap Assets API * Fix typos * Update document header * Add precision about emitter country * SIP-29 Improvements (#155) * add handlers and permission definition * update to use `snaps-sdk` * snap -> Snap * Add CAIP-19 ID reference in description and rename token to asset * Add chains caveat * fix typo * allow batching * add fungible reference to asset description * add appendix for fungible assets * fix typos * update rates handler to support batching * unify * rename `AssetUnit` to `FungibleAssetUnit` * Fix formatting * Rename `ticker` to `symbol` It should be closer to the terminology used by the Token API. * Fix capitalization Co-authored-by: Charly Chevalier <[email protected]> * Update comment Co-authored-by: Charly Chevalier <[email protected]> * Update comment Co-authored-by: Charly Chevalier <[email protected]> * Add link to CAIP-19 Co-authored-by: Charly Chevalier <[email protected]> * Fix formatting Co-authored-by: Charly Chevalier <[email protected]> * Rename `OnAssetLookupReturn` to `OnAssetLookupResponse` Co-authored-by: Frederik Bolding <[email protected]> * Rename `OnAssetConversionReturn` to `OnAssetConversionResponse` Co-authored-by: Frederik Bolding <[email protected]> * Add missing `AssetMetadata` type * Rename `OnAssetLookupArgs` to `OnAssetLookupArguments` Co-authored-by: Frederik Bolding <[email protected]> * Rename `OnAssetConversionArgs` to `OnAssetConversionArguments` Co-authored-by: Frederik Bolding <[email protected]> * Remove placeholder section Co-authored-by: Maarten Zuidhoorn <[email protected]> * Address requested changes - Update the handler names to be pluralised - Describe `Caip19AssetType` - Add some text about how the rates are represented * More improvements - Allow data URI and URL for token icons - Make conversion rate expiration time optional - Add note about asset filtering if out of scope - Remove native key from asset description - Typo fixes * address requested changes --------- Co-authored-by: Guillaume Roux <[email protected]> Co-authored-by: Charly Chevalier <[email protected]> Co-authored-by: Frederik Bolding <[email protected]> Co-authored-by: Maarten Zuidhoorn <[email protected]> Co-authored-by: Guillaume Roux <[email protected]>
- Loading branch information