Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIP-30: Entropy Source Identifiers #156

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

SIP-30: Entropy Source Identifiers #156

wants to merge 3 commits into from

Conversation

shane-t
Copy link
Member

@shane-t shane-t commented Dec 17, 2024

No description provided.

@shane-t shane-t requested review from Montoya and a team as code owners December 17, 2024 15:14
@shane-t shane-t marked this pull request as draft December 17, 2024 15:15
@shane-t shane-t force-pushed the sto/sip-30/multi-SRP branch from ba75faa to 9571b7a Compare December 18, 2024 11:25
@shane-t shane-t changed the title Draft: SIP-30 - request entropy from multiple sources SIP-30 Dec 18, 2024
@shane-t shane-t changed the title SIP-30 SIP-30: Entropy Source Identifiers Dec 18, 2024
@shane-t shane-t force-pushed the sto/sip-30/multi-SRP branch from 9571b7a to 3d7bdaf Compare December 18, 2024 11:27
@shane-t shane-t marked this pull request as ready for review December 18, 2024 11:37
@Montoya
Copy link
Contributor

Montoya commented Dec 18, 2024

Why does this have to be a new API? If it involves a new optional parameter, it can be backwards compatible. If the Snap does not include the parameter in the request, default to the legacy behavior. If the parameter is included, then use that parameter to identify the entropy source.

@shane-t
Copy link
Member Author

shane-t commented Dec 20, 2024

Why does this have to be a new API? If it involves a new optional parameter, it can be backwards compatible. If the Snap does not include the parameter in the request, default to the legacy behavior. If the parameter is included, then use that parameter to identify the entropy source.

That's the general idea. We retain all the snap_get*Entropy methods but include a new source parameter

@shane-t
Copy link
Member Author

shane-t commented Dec 20, 2024

@Montoya I've added a section describing the behaviour if the parameter is not included

FrederikBolding
FrederikBolding reviewed Dec 20, 2024
View reviewed changes
SIPS/sip-30.md
// }
```

#### `snap_getBip32PublicKeyFromSource`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### `snap_getBip32PublicKeyFromSource`
#### `snap_getBip32PublicKey`

FrederikBolding
FrederikBolding reviewed Dec 20, 2024
View reviewed changes
SIPS/sip-30.md

### New RPC Methods

#### `snap_listAvailableEntropySources`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### `snap_listAvailableEntropySources`
#### `snap_listEntropySources`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederikBolding FrederikBolding FrederikBolding left review comments

@Montoya Montoya Awaiting requested review from Montoya Montoya is a code owner

@Mrtenz Mrtenz Awaiting requested review from Mrtenz

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shane-t @Montoya @FrederikBolding