chore: update bnb logo #1334
Merged
chore: update bnb logo #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gambinish SVG logo is required in all new PRs |
This was referenced Jul 25, 2024
|
salimtb
approved these changes
Jul 25, 2024
gambinish
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Jul 25, 2024
## **Description** Updates BNB logos to updated png assets ## **Related issues** Fixes: MMASSETS-221 ## **Manual testing steps** Run app in light and dark mode and validate that all BNB network icons are updated. Note that erc20 token assets may not be correctly reflected until MetaMask/contract-metadata#1334 is merged. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="350" alt="Screenshot 2024-07-25 at 9 32 20 AM" src="https://github.com/user-attachments/assets/58ffab8c-2816-4abc-93ec-8574de029d68"> <img width="350" alt="Screenshot 2024-07-25 at 9 32 35 AM" src="https://github.com/user-attachments/assets/59b37e4f-3b10-498b-9883-84dc7c674708"> <img width="352" alt="Screenshot 2024-07-25 at 9 37 57 AM" src="https://github.com/user-attachments/assets/1bbd4b08-5e78-45a3-9088-5e0925920995"> <img width="352" alt="Screenshot 2024-07-25 at 9 38 18 AM" src="https://github.com/user-attachments/assets/3cbffb89-558b-43b2-b5e6-d74965022250"> ### **After** <img width="349" alt="Screenshot 2024-07-25 at 9 50 25 AM" src="https://github.com/user-attachments/assets/74084ef9-93e9-43a0-8b2c-3df23ba94f6c"> <img width="350" alt="Screenshot 2024-07-25 at 9 50 43 AM" src="https://github.com/user-attachments/assets/04956cb2-7484-467a-aa43-b5fe962df112"> <img width="352" alt="Screenshot 2024-07-25 at 9 49 41 AM" src="https://github.com/user-attachments/assets/60b62430-7d51-4e51-89bb-1b143366a44a"> <img width="351" alt="Screenshot 2024-07-25 at 9 49 53 AM" src="https://github.com/user-attachments/assets/381dde1d-4aae-48a7-957d-34738f91e0cf"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
gambinish
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jul 25, 2024
## **Description** Updates BNB network logo to the newly provided png and svg assets. [](https://codespaces.new/MetaMask/metamask-extension/pull/26140?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** Load app and validate that BNB chain logos are updated. Note that erc20 token logos will not update until MetaMask/contract-metadata#1334 gets merged. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="300" alt="Screenshot 2024-07-25 at 10 20 48 AM" src="https://github.com/user-attachments/assets/1657af96-71b3-4d53-9308-3b5d4127d960"> <img width="300" alt="Screenshot 2024-07-25 at 10 21 06 AM" src="https://github.com/user-attachments/assets/cbda47bf-2dcb-481c-9530-6eda74b9b3e7"> <img width="300" alt="Screenshot 2024-07-25 at 10 22 32 AM" src="https://github.com/user-attachments/assets/8be43670-298e-4b18-900f-3943eac4d310"> <img width="300" alt="Screenshot 2024-07-25 at 10 22 52 AM" src="https://github.com/user-attachments/assets/10762e9f-c0ce-4871-964b-10e0d2112e82"> ### **After** <img width="300" alt="Screenshot 2024-07-25 at 10 38 18 AM" src="https://github.com/user-attachments/assets/ab3ae389-6a68-451f-ae80-b4437343bf8b"> <img width="300" alt="Screenshot 2024-07-25 at 10 38 59 AM" src="https://github.com/user-attachments/assets/80b66ffa-1ad2-422f-86b7-852b6e3b3555"> <img width="300" alt="Screenshot 2024-07-25 at 10 39 52 AM" src="https://github.com/user-attachments/assets/2239643d-401a-4ae8-9850-2495d0c28d69"> <img width="300" alt="Screenshot 2024-07-25 at 10 40 15 AM" src="https://github.com/user-attachments/assets/0c549632-6a1b-4ba4-8bfc-e34b80752fd2"> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
mikesposito
approved these changes
Jul 26, 2024
MRabenda
approved these changes
Jul 26, 2024
|
Thank you @gambinish |
](https://codespaces.new/MetaMask/metamask-extension/pull/26140?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates BNB logo to the newly provided png so that erc20 token logos in the extension/mobile app display the updated logo similar to how the chain/network logos are displayed in app.
Opted not to update the
contract-map.jsonas no filenames or configurations changed.Related issues
Fixes: MMASSETS-221