-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for BAG token #1346
Conversation
Hey, before We would be able to merge it - I would like to improve icon quality:
|
@MRabenda thanks for the followup, we were able to get it down ~25kb, is that sufficient. This is the smallest we could get it while keeping the colors intact. |
Hey, sorry @Garchbold but in the code of the image we can find
This is actually still PNG raster image instead of SVG vector one |
Hey @MRabenda just checking in again is there still an outstanding issue for this pr? |
I would be able to merge it with proper vector image, not a PNG saved as SVG |
is 70 kB sufficient, after switching it to a proper vector image thats the size that we end up at |
If is a full vector that should be fine, please update it |
Hey @MRabenda just updated, please let me know if that works, thank you |
Hey, Icon looks good - last missing element is that address should be in EIP-55 format - the correct one would look like 0x808688c820AB080A6Ff1019F03E5EC227D9b522B |
Thanks for all the patience @MRabenda it should be ready now |
when could we expect this to be reflected in prod? |
Hey @MRabenda We are still seeing the incorrect image in metamask on polygon, is there a another repo we need to fork for the image to show up there? |
Hello @Garchbold 👋 |
No description provided.