Use Prettier to format changelogs #3850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newest version of `create-release-branch` formats changelogs with Prettier after it updates them. This assumes that the project using `create-release-branch` (this one) already formats changelogs via Prettier. This isn't enabled yet, so this commit does that.
Gudahtt
reviewed
Jan 25, 2024
| @@ -11,7 +11,7 @@ package_name="$1" | |||
| shift # remove package name from arguments | |||
|
|
|||
| if [[ "${GITHUB_REF:-}" =~ '^release/' ]]; then | |||
| yarn auto-changelog validate --tag-prefix "${package_name}@" --rc "$@" | |||
| yarn auto-changelog validate --prettier --tag-prefix "${package_name}@" --rc "$@" | |||
There was a problem hiding this comment.
I think we'll want the same flag added to update-changelog.sh as well
There was a problem hiding this comment.
Yes, good call. Updated in 4c39092.
Gudahtt
approved these changes
Jan 25, 2024
Mrtenz
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The newest version of
create-release-branchformats changelogs with Prettier after it updates them. This assumes that the project usingcreate-release-branch(this one) already formats changelogs via Prettier. This isn't enabled yet, so this commit does that.References
Also see: MetaMask/create-release-branch#100
Changelog
(N/A)
Checklist