Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Solana to the polled exchange rates #4914

Conversation

ulissesferreira
Copy link
Contributor

@ulissesferreira ulissesferreira commented Nov 11, 2024

Explanation

As we aim to support more chains in the MetaMask extension we will need the exchange rates of the native tokens of these chains to properly value a user's account. Let's add Solana to the cryptocurrencies that we need to keep track of price.

References

Closes SOL-36

Changelog

@metamask/assets-controller

  • feat: add Solana to the polled exchange rates

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ulissesferreira ulissesferreira requested a review from a team as a code owner November 11, 2024 16:35
@ulissesferreira ulissesferreira force-pushed the SOL-36-metamask-core-update-rate-controller-in-assets-controllers-package branch from f7396b3 to 0787f99 Compare November 11, 2024 16:55
@ulissesferreira ulissesferreira force-pushed the SOL-36-metamask-core-update-rate-controller-in-assets-controllers-package branch from 0787f99 to 1b536ac Compare November 11, 2024 17:00
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.3-preview-1b536ac",
  "@metamask-previews/address-book-controller": "6.0.1-preview-1b536ac",
  "@metamask-previews/announcement-controller": "7.0.1-preview-1b536ac",
  "@metamask-previews/approval-controller": "7.1.1-preview-1b536ac",
  "@metamask-previews/assets-controllers": "42.0.0-preview-1b536ac",
  "@metamask-previews/base-controller": "7.0.2-preview-1b536ac",
  "@metamask-previews/build-utils": "3.0.1-preview-1b536ac",
  "@metamask-previews/chain-controller": "0.1.3-preview-1b536ac",
  "@metamask-previews/composable-controller": "9.0.1-preview-1b536ac",
  "@metamask-previews/controller-utils": "11.4.2-preview-1b536ac",
  "@metamask-previews/ens-controller": "15.0.0-preview-1b536ac",
  "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-1b536ac",
  "@metamask-previews/gas-fee-controller": "22.0.0-preview-1b536ac",
  "@metamask-previews/json-rpc-engine": "10.0.1-preview-1b536ac",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-1b536ac",
  "@metamask-previews/keyring-controller": "17.3.1-preview-1b536ac",
  "@metamask-previews/logging-controller": "6.0.1-preview-1b536ac",
  "@metamask-previews/message-manager": "11.0.1-preview-1b536ac",
  "@metamask-previews/multichain": "0.0.0-preview-1b536ac",
  "@metamask-previews/name-controller": "8.0.1-preview-1b536ac",
  "@metamask-previews/network-controller": "22.0.1-preview-1b536ac",
  "@metamask-previews/notification-controller": "7.0.0-preview-1b536ac",
  "@metamask-previews/notification-services-controller": "0.12.1-preview-1b536ac",
  "@metamask-previews/permission-controller": "11.0.3-preview-1b536ac",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-1b536ac",
  "@metamask-previews/phishing-controller": "12.3.0-preview-1b536ac",
  "@metamask-previews/polling-controller": "12.0.1-preview-1b536ac",
  "@metamask-previews/preferences-controller": "13.3.0-preview-1b536ac",
  "@metamask-previews/profile-sync-controller": "0.9.8-preview-1b536ac",
  "@metamask-previews/queued-request-controller": "7.0.1-preview-1b536ac",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-1b536ac",
  "@metamask-previews/selected-network-controller": "19.0.0-preview-1b536ac",
  "@metamask-previews/signature-controller": "21.1.0-preview-1b536ac",
  "@metamask-previews/transaction-controller": "38.3.0-preview-1b536ac",
  "@metamask-previews/user-operation-controller": "17.0.0-preview-1b536ac"
}

@ulissesferreira ulissesferreira enabled auto-merge (squash) November 13, 2024 11:37
@ulissesferreira ulissesferreira merged commit fe985d2 into main Nov 13, 2024
120 checks passed
@ulissesferreira ulissesferreira deleted the SOL-36-metamask-core-update-rate-controller-in-assets-controllers-package branch November 13, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants