Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transaction resubmit on multiple endpoints #5262

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Feb 3, 2025

Explanation

Update PendingTransactionTracker to filter pending transactions using the network client ID of the instance.

This prevents multiple instances with different network client IDs, but the same chain, from processing the same transactions.

References

Changelog

@metamask/transaction-controller

  • FIXED: Prevent resubmit on multiple endpoints.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthewwalsh0 matthewwalsh0 changed the title fix: filter pending transactions by network client ID fix: transaction resubmit on multiple endpoints Feb 3, 2025
@matthewwalsh0
Copy link
Member Author

@metamaskbot publish-preview

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "22.0.0-preview-ee77a6d9",
  "@metamask-previews/address-book-controller": "6.0.2-preview-ee77a6d9",
  "@metamask-previews/announcement-controller": "7.0.2-preview-ee77a6d9",
  "@metamask-previews/approval-controller": "7.1.2-preview-ee77a6d9",
  "@metamask-previews/assets-controllers": "47.0.0-preview-ee77a6d9",
  "@metamask-previews/base-controller": "7.1.1-preview-ee77a6d9",
  "@metamask-previews/build-utils": "3.0.2-preview-ee77a6d9",
  "@metamask-previews/composable-controller": "10.0.0-preview-ee77a6d9",
  "@metamask-previews/controller-utils": "11.4.5-preview-ee77a6d9",
  "@metamask-previews/earn-controller": "0.0.0-preview-ee77a6d9",
  "@metamask-previews/ens-controller": "15.0.1-preview-ee77a6d9",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-ee77a6d9",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-ee77a6d9",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-ee77a6d9",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-ee77a6d9",
  "@metamask-previews/keyring-controller": "19.0.5-preview-ee77a6d9",
  "@metamask-previews/logging-controller": "6.0.3-preview-ee77a6d9",
  "@metamask-previews/message-manager": "12.0.0-preview-ee77a6d9",
  "@metamask-previews/multichain": "2.1.0-preview-ee77a6d9",
  "@metamask-previews/multichain-transactions-controller": "0.1.0-preview-ee77a6d9",
  "@metamask-previews/name-controller": "8.0.2-preview-ee77a6d9",
  "@metamask-previews/network-controller": "22.1.1-preview-ee77a6d9",
  "@metamask-previews/notification-services-controller": "0.18.0-preview-ee77a6d9",
  "@metamask-previews/permission-controller": "11.0.5-preview-ee77a6d9",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-ee77a6d9",
  "@metamask-previews/phishing-controller": "12.3.1-preview-ee77a6d9",
  "@metamask-previews/polling-controller": "12.0.2-preview-ee77a6d9",
  "@metamask-previews/preferences-controller": "15.0.1-preview-ee77a6d9",
  "@metamask-previews/profile-sync-controller": "5.0.0-preview-ee77a6d9",
  "@metamask-previews/queued-request-controller": "9.0.0-preview-ee77a6d9",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-ee77a6d9",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-ee77a6d9",
  "@metamask-previews/selected-network-controller": "21.0.0-preview-ee77a6d9",
  "@metamask-previews/signature-controller": "23.2.0-preview-ee77a6d9",
  "@metamask-previews/token-search-discovery-controller": "1.0.0-preview-ee77a6d9",
  "@metamask-previews/transaction-controller": "44.0.0-preview-ee77a6d9",
  "@metamask-previews/user-operation-controller": "23.0.0-preview-ee77a6d9"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant