Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/297.0.0 #5305

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Release/297.0.0 #5305

wants to merge 12 commits into from

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Feb 7, 2025 •
edited
Loading

Explanation

Major core release affecting all packages. This release delivers the latest version of BaseController, incorporating two significant breaking changes: the removal of BaseControllerV1 and the removal of old Messenger aliases.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@cryptodev-2s cryptodev-2s self-assigned this Feb 7, 2025
@cryptodev-2s cryptodev-2s requested review from a team as code owners February 7, 2025 22:07
mcmire
mcmire reviewed Feb 7, 2025
View reviewed changes
packages/accounts-controller/package.json Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Show resolved Hide resolved
packages/multichain-transactions-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved
packages/token-search-discovery-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/transaction-controller/CHANGELOG.md

### Changed

- Bump `@metamask/base-controller` from `^7.1.1` to `^8.0.0` ([#5305](https://github.com/MetaMask/core/pull/5305))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like 5285 contained breaking changes to the messenger that aren't captured here:

Suggested change
- Bump `@metamask/base-controller` from `^7.1.1` to `^8.0.0` ([#5305](https://github.com/MetaMask/core/pull/5305))
- **BREAKING:** The TransactionController messenger must now allow the `KeyringController:signAuthorization` action ([#5285](https://github.com/MetaMask/core/pull/5285))
- Bump `@metamask/base-controller` from `^7.1.1` to `^8.0.0` ([#5305](https://github.com/MetaMask/core/pull/5305))

@matthewwalsh0 Can you confirm this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

packages/transaction-controller/CHANGELOG.md Show resolved Hide resolved
@socket-security Socket Security
Copy link

socket-security bot commented Feb 7, 2025 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@mcmire mcmire Awaiting requested review from mcmire

@Bigshmow Bigshmow Awaiting requested review from Bigshmow

At least 1 approving review is required to merge this pull request.

Assignees

@cryptodev-2s cryptodev-2s

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cryptodev-2s @mcmire @sahar-fehri @Bigshmow